Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new scenario for ECAL ALCANANO and update the unit test #37627

Merged
merged 1 commit into from Apr 20, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Apr 19, 2022

PR description:

By doing the T0 replay
dmwm/T0#4664
I realized that the relvals run

steps['RECOALCAECALPHISYMDR3']=merge([{'--scenario':'pp',
                                       '--era':'Run3',
                                       '--conditions':'auto:run3_data_prompt',
                                       '--datatier':'RECO',
                                       '--eventcontent':'RECO',
                                       '-n':'-1',
                                       '-s':'RECO:bunchSpacingProducer+ecalMultiFitUncalibRecHitTask+ecalCalibratedRecHitTask',
                                       '--customise':'Calibration/EcalCalibAlgos/EcalPhiSymRecoSequence_cff'},dataReco])

and the customization in T0 happens through scenarios, so this PR adds the needed scenario.

PR validation:

scram b runtests runs and produces a config that for example contains the ecalMultiFitUncalibRecHitTask task.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Needs to be backported to 12_3_X for dmwm/T0#4664 to work

@tvami
Copy link
Contributor Author

tvami commented Apr 19, 2022

FYI @simonepigazzini @cms-sw/alca-l2 @mmusich @rappoccio

@tvami
Copy link
Contributor Author

tvami commented Apr 19, 2022

urgent

  • actually if this goes into 12_4_0_pre3 we could use that for the replay

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37627/29398

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Apr 19, 2022

@tvami
there's an empty file committed: Configuration/DataProcessing/test/RunPromptReco.py, I guess you want to get rid of that.

@tvami
Copy link
Contributor Author

tvami commented Apr 19, 2022

Hi Marco, the file is not empty, the change is "empty", I changed the permissions of the file, earlier it was not executable so when I tried to run the unit test line directly, I got permission denied. Do you think think I should change back the permissions?

@mmusich
Copy link
Contributor

mmusich commented Apr 19, 2022

Do you think think I should change back the permissions?

Not sure, I usually invoked the script by calling it with python. In recent releases you want to use python3 instead.

@tvami
Copy link
Contributor Author

tvami commented Apr 19, 2022

Do you think think I should change back the permissions?

Not sure, I usually invoked the script by calling it with python

That leads to

  File "Configuration/DataProcessing/test/RunPromptReco.py", line 14, in <module>
    from Configuration.DataProcessing.GetScenario import getScenario
ImportError: No module named Configuration.DataProcessing.GetScenario

@tvami
Copy link
Contributor Author

tvami commented Apr 19, 2022

oh but doing python3 it works, I'll change back the permissions!

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37627/29400

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #37627 was updated. @cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

@tvami
Copy link
Contributor Author

tvami commented Apr 19, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-104cbf/24033/summary.html
COMMIT: 66debc8
CMSSW: CMSSW_12_4_X_2022-04-19-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37627/24033/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.503 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3589937
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3589895
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Apr 20, 2022

@cms-sw/operations-l2 the tests came back positive, please consider signing this

@tvami
Copy link
Contributor Author

tvami commented Apr 20, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37627/29411

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #37627 was updated. @perrotta, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-104cbf/24053/summary.html
COMMIT: 29db0e6
CMSSW: CMSSW_12_4_X_2022-04-20-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37627/24053/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-104cbf/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695434
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695410
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants