Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase1 gem02 #3776

Merged
merged 2 commits into from May 19, 2014
Merged

Phase1 gem02 #3776

merged 2 commits into from May 19, 2014

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented May 9, 2014

Update shield in ME11

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

A new Pull Request was created by @bsunanda for CMSSW_6_2_X_SLHC.

Phase1 gem02

It involves the following packages:

Geometry/MuonCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

just to clarify - this breaks the compatibility with the existing GEN-SIM samples (SLHC12, 2019 and 2023Muon geometries), correct?

@ianna
Copy link
Contributor

ianna commented May 14, 2014

+1

@davidlange6 - it modifies only passive material, so it does not break the compatibility with the existing GEN-SIM samples

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@davidlange6
Copy link
Contributor

ok - thanks!

On May 14, 2014, at 4:15 PM, ianna notifications@github.com
wrote:

+1

@davidlange6 - it modifies only passive material, so it does not break the compatibility with the existing GEN-SIM samples


Reply to this email directly or view it on GitHub.

@andersonjacob
Copy link
Contributor

@bsunanda Can you rebase this branch to the head and fix the merge problems. After @ianna cleaned things up there are conflicts

@ianna
Copy link
Contributor

ianna commented May 16, 2014

@bsunanda - MuonCommonData/data/PhaseII contains upgrade detectors with ME0 included. The sub-directory NoME0 includes the same without ME0. The v2 and v3 sub-directories were deleted. All scenarios have been updated to use the new structure. Sorry, I did not realise your PR was not in yesterday's IB.

@bsunanda
Copy link
Contributor Author

I do not fully appreciate this meesage. Do we still have the different
GE11 partitions - 6, 8, 10, mixed S+L with 9+10, 8+8, 8+8 radial ones? I
think the exercise of evaluating them is not over. Also I am a bit
confused if is GE11 for PhaseII or PhaseI. Once I see the IB I think it
will become clear to me. Cheers Sunanda

On Fri, 16 May 2014, ianna wrote:

@bsunanda - MuonCommonData/data/PhaseII contains upgrade detectors with ME0
included. The sub-directory NoME0 includes the same without ME0. The v2 and
v3 sub-directories were deleted. All scenarios have been updated to use the
new structure. Sorry, I did not realise your PR was not in yesterday's IB.


Reply to this email directly or view it onGitHub.[5033146__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNTgzNT
EzMSwiZGF0YSI6eyJpZCI6MzE4MzM5MDN9fQ==--ac93e5df3517e5d2ce449a64a4850c057a1
5a38f.gif]

@ianna
Copy link
Contributor

ianna commented May 16, 2014

@bsunanda - GEM directory structure is not changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants