Properly pass strings to Fortran in two generators

[Dr15Jones]

PR description:

• Fortran string arrays are fixed size and padded with spaces.

PR validation:

Code compiles and workflow 575.0 runs fine on x86. I do not know what machine to use to test on ARM.

fixes #37799

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37840/29766

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• GeneratorInterface/AMPTInterface (generators)
• GeneratorInterface/HijingInterface (generators)

@alberto-sanchez, @SiewYan, @mkirsano, @Saptaparna, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ccb46/24496/summary.html
COMMIT: 611ca90
CMSSW: CMSSW_12_4_X_2022-05-06-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37840/24496/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cecilecaillol L1T fix reading array beyond bounds #37700
• @mmusich remove some deprecation warnings from DQMServices/Components #37747
• @cecilecaillol [L1T] Fix issue in loop going beyond array bounds #37705
• @quark2 Gathering detail plots into directories, online & offline & relval & … #37786

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ccb46/24496/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ccb46/24496/git-merge-result

Comparison Summary

Summary:

• You potentially added 189812 lines to the logs
• Reco comparison results: 19 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3697945
• DQMHistoTests: Total failures: 22
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3697901
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 65153.668 KiB( 48 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 147.714 KiB GEM/Digis
• DQMHistoSizes: changed ( 10024.0,... ): -18.914 KiB GEM/RecHits
• DQMHistoSizes: changed ( 11634.0,... ): 2170.807 KiB GEM/Digis
• DQMHistoSizes: changed ( 11634.0,... ): 11.172 KiB GEM/RecHits
• DQMHistoSizes: changed ( 11634.0,... ): 0.770 KiB GEM/EventInfo
• DQMHistoSizes: changed ( 23234.0,... ): 4332.684 KiB GEM/Digis
• DQMHistoSizes: changed ( 23234.0,... ): -5.781 KiB GEM/RecHits
• DQMHistoSizes: changed ( 35034.0,... ): 6048.131 KiB GEM/Digis
• DQMHistoSizes: changed ( 35034.0,... ): -13.969 KiB GEM/RecHits
• Checked 206 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[SiewYan]

@smuzaffar , is that a way to trigger test on el8_aarch64_gcc10 or equivalent ?

[smuzaffar]

@SiewYan , yes by adding a comment please test for el8_aarch64_gcc10

[SiewYan]

please test for el8_aarch64_gcc10

[smuzaffar]

test parameters:

• workflow = 575.0

[smuzaffar]

@SiewYan , our ARM64 node has full disk and we are not able to test/build any aarch64 IBs/PRs. CERN Openlab team is looking in to the issue.

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ccb46/24534/summary.html
COMMIT: 611ca90
CMSSW: CMSSW_12_4_X_2022-05-06-2300/el8_aarch64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37840/24534/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

[smuzaffar]

workflow 575.0 now passed for aarch64

[SiewYan]

+1

Thanks @smuzaffar!

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1