Dump of the beamspot for DIP #37858

gennai · 2022-05-09T08:02:43Z

PR description:

this PR adds the dump of the beamspot parameters that are the uploaded in DIP.

PR validation:

I have run Online_BeamMonitor_file.py in the test directory to check that the printed information is correct

gennai · 2022-05-09T08:03:56Z

@francescobrivio @dzuolo you may want to follow this as well

gennai · 2022-05-09T08:04:19Z

and @sikler too

cmsbuild · 2022-05-09T08:10:29Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37858/29800

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37858/29800/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37858/29800/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

francescobrivio

In addition could you update the refresh time in

cmssw/DQM/Integration/python/clients/onlinebeammonitor_dqm_sourceclient-live_cfg.py

Lines 143 to 151 in d1be6d9

    
           process.GlobalTag.toGet = cms.VPSet( 
        
             cms.PSet( 
        
               record = cms.string("BeamSpotOnlineLegacyObjectsRcd"), 
        
               refreshTime = cms.uint64(1) 
        
             ), 
        
             cms.PSet( 
        
               record = cms.string("BeamSpotOnlineHLTObjectsRcd"), 
        
               refreshTime = cms.uint64(1) 
        
             )

?

francescobrivio · 2022-05-09T08:07:51Z

DQM/BeamMonitor/plugins/OnlineBeamMonitor.cc

@@ -199,6 +213,7 @@ std::shared_ptr<onlinebeammonitor::NoCache> OnlineBeamMonitor::globalBeginLumino
  }
  if (auto bsTransientHandle = iSetup.getHandle(bsTransientToken_)) {
    auto const& spotDB = *bsTransientHandle;
+    std::cout <<" from the DB "<<spotDB<<std::endl;


Can you remove the cout (or replace it with edm::LogInfo)?

i forgot to remove it, doing it now (it was just a test)

francescobrivio · 2022-05-09T08:11:46Z

DQM/BeamMonitor/test/Online_BeamMonitor_file.py

+MonitorName         = cms.untracked.string("onlineBeamMonitor"),
+AppendRunToFileName = cms.untracked.bool(False),
+WriteDIPAscii       = cms.untracked.bool(True),
+DIPFileName         = cms.untracked.string("BeamFitResultsForDIP.txt")


Do we need to add the same options also in

cmssw/DQM/Integration/python/clients/onlinebeammonitor_dqm_sourceclient-live_cfg.py

Line 128 in d1be6d9

process.dqmOnlineBeamMonitor = cms.EDProducer("OnlineBeamMonitor",

?

Actually the easiest way would be to clone the onlinebeammonitor configuration so that we do not have to add the extra parameters, but i agree this file has to be changed

cmsbuild · 2022-05-09T08:39:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37858/29801

This PR adds an extra 24KB to repository

cmsbuild · 2022-05-09T08:40:15Z

A new Pull Request was created by @gennai (simone gennai) for master.

It involves the following packages:

DQM/BeamMonitor (dqm, db)
DQM/Integration (dqm)

@malbouis, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mmusich, @battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

francescobrivio · 2022-05-09T08:50:39Z

DQM/Integration/python/clients/onlinebeammonitor_dqm_sourceclient-live_cfg.py

+MonitorName         = cms.untracked.string("OnlineBeamMonitor"),
+AppendRunToFileName = cms.untracked.bool(False),
+WriteDIPAscii       = cms.untracked.bool(True),
+DIPFileName         = cms.untracked.string("BeamFitResultsForDIP.txt")


Sorry Simone I forgot to add that the DIP filename should probably contain the full /nfshome0 path, similar to

cmssw/DQM/Integration/python/clients/beamhlt_dqm_sourceclient-live_cfg.py

Line 128 in d1be6d9

process.dqmBeamMonitor.BeamFitter.DIPFileName = '/nfshome0/dqmpro/BeamMonitorDQM/BeamFitResults.txt'

done in the latest commit

cmsbuild · 2022-05-09T09:16:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37858/29802

This PR adds an extra 24KB to repository

cmsbuild · 2022-05-09T09:16:59Z

Pull request #37858 was updated. @malbouis, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.

sikler · 2022-05-09T09:27:44Z

Hi @gennai , @francescobrivio , please let me know once this is settled, since in any case I would have to modify #37817 and #37835 to match the format/name/content of the .txt you write out (e,g, adding TkStatus, etc). Thanks

cmsbuild · 2022-05-10T11:27:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37858/29871

This PR adds an extra 28KB to repository

cmsbuild · 2022-05-10T11:27:37Z

Pull request #37858 was updated. @malbouis, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.

gennai · 2022-05-11T13:44:21Z

can anybody start the jenkins test?

mmusich · 2022-05-11T13:48:05Z

please test

perrotta · 2022-05-11T13:49:11Z

please test

cmsbuild · 2022-05-11T18:36:54Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fd3d3/24624/summary.html
COMMIT: 0cdd940
CMSSW: CMSSW_12_4_X_2022-05-11-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37858/24624/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3697209
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3697179
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 206 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

francescobrivio · 2022-05-12T13:42:16Z

+db

emanueleusai · 2022-05-12T16:23:17Z

+1

cmsbuild · 2022-05-12T16:23:41Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2022-05-13T01:58:49Z

+1

added the dump of the beamspot parameters to be uploaded in DIP

42d219f

cmsbuild added this to the CMSSW_12_4_X milestone May 9, 2022

cmsbuild added code-checks-pending db-pending dqm-pending orp-pending pending-signatures tests-pending labels May 9, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 9, 2022

francescobrivio reviewed May 9, 2022

View reviewed changes

applyed code patch and implemented Francesco's comments

c7ba291

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 9, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels May 9, 2022

francescobrivio reviewed May 9, 2022

View reviewed changes

added the full path for the dip file name

1d92991

cmsbuild added code-checks-pending and removed code-checks-approved labels May 9, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels May 9, 2022

applied code style patch

0cdd940

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 10, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels May 10, 2022

cmsbuild added tests-started and removed tests-pending labels May 11, 2022

cmsbuild added tests-approved and removed tests-started labels May 11, 2022

cmsbuild added db-approved and removed db-pending labels May 12, 2022

francescobrivio mentioned this pull request May 12, 2022

[12_3_X] Dump of the beamspot for DIP #37928

Merged

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels May 12, 2022

cmsbuild added orp-approved and removed orp-pending labels May 13, 2022

cmsbuild merged commit adbc7db into cms-sw:master May 13, 2022

cmsbuild mentioned this pull request May 13, 2022

RecoTracker/MkFitCore: factorize loops to allow gcc -msse3 to vectorize loops #37868

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dump of the beamspot for DIP #37858

Dump of the beamspot for DIP #37858

gennai commented May 9, 2022

gennai commented May 9, 2022

gennai commented May 9, 2022

cmsbuild commented May 9, 2022

francescobrivio left a comment

francescobrivio May 9, 2022 •

edited

gennai May 9, 2022

francescobrivio May 9, 2022

gennai May 9, 2022

cmsbuild commented May 9, 2022

cmsbuild commented May 9, 2022

francescobrivio May 9, 2022

gennai May 9, 2022

cmsbuild commented May 9, 2022

cmsbuild commented May 9, 2022

sikler commented May 9, 2022

cmsbuild commented May 10, 2022

cmsbuild commented May 10, 2022

gennai commented May 11, 2022

mmusich commented May 11, 2022

perrotta commented May 11, 2022

cmsbuild commented May 11, 2022

francescobrivio commented May 12, 2022

emanueleusai commented May 12, 2022

cmsbuild commented May 12, 2022

qliphy commented May 13, 2022

	process.GlobalTag.toGet = cms.VPSet(
	cms.PSet(
	record = cms.string("BeamSpotOnlineLegacyObjectsRcd"),
	refreshTime = cms.uint64(1)
	),
	cms.PSet(
	record = cms.string("BeamSpotOnlineHLTObjectsRcd"),
	refreshTime = cms.uint64(1)
	)

Dump of the beamspot for DIP #37858

Dump of the beamspot for DIP #37858

Conversation

gennai commented May 9, 2022

PR description:

PR validation:

gennai commented May 9, 2022

gennai commented May 9, 2022

cmsbuild commented May 9, 2022

francescobrivio left a comment

Choose a reason for hiding this comment

francescobrivio May 9, 2022 • edited

Choose a reason for hiding this comment

gennai May 9, 2022

Choose a reason for hiding this comment

francescobrivio May 9, 2022

Choose a reason for hiding this comment

gennai May 9, 2022

Choose a reason for hiding this comment

cmsbuild commented May 9, 2022

cmsbuild commented May 9, 2022

francescobrivio May 9, 2022

Choose a reason for hiding this comment

gennai May 9, 2022

Choose a reason for hiding this comment

cmsbuild commented May 9, 2022

cmsbuild commented May 9, 2022

sikler commented May 9, 2022

cmsbuild commented May 10, 2022

cmsbuild commented May 10, 2022

gennai commented May 11, 2022

mmusich commented May 11, 2022

perrotta commented May 11, 2022

cmsbuild commented May 11, 2022

Comparison Summary

francescobrivio commented May 12, 2022

emanueleusai commented May 12, 2022

cmsbuild commented May 12, 2022

qliphy commented May 13, 2022

francescobrivio May 9, 2022 •

edited