Addition of moduleType variable in tracking NTuple

[VourMa]

PR description:

This PR includes an update to the tracking NTuple to include information about the module type. It only adds the relevant branches to the NTuple and doesn't bring about any other change.

PR validation:

The code has been tested locally to create the tracking NTuple with the new branches properly created and filled.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37893/29881

• This PR adds an extra 48KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37893/29881/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37893/29881/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37893/29882

• This PR adds an extra 48KB to repository

[cmsbuild]

A new Pull Request was created by @VourMa (Manos Vourliotis) for master.

It involves the following packages:

• Validation/RecoTrack (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @wmtford, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

type tracking

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12c708/24586/summary.html
COMMIT: d756fd1
CMSSW: CMSSW_12_4_X_2022-05-10-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37893/24586/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @panoskatsoulis Enable forceGeneration for L1 O2O online producers #37861
• @jbsauvan implement multiple working points in ID for e/g triggers based on HGCAL clusters #37758
• @Dr15Jones Fix CMS deprecation warnings in PhysicsTools/IsolationAlgos #37847

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12c708/24586/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12c708/24586/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3696633
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3696609
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 206 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: found differences in 1 / 48 workflows

[slava77]

@cms-sw/dqm-l2
does this have a chance to make it to 124Xpre4, to avoid backports?

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[emanueleusai]

@slava77 We are running 12_3 at P5, so if you want this running at P5 asap we would need a backport to 12_3

[mmusich]

@emanueleusai

so if you want this running at P5 asap we would need a backport to 12_3

this is validation, not DQM, so running at P5 is irrelevant.
Incidentally it's also targeting phase-2...

[emanueleusai]

12.4.0pre4 closes today or tomorrow. I do not have more detailed information than this.

[perrotta]

+1

[slava77]

12.4.0pre4 closes today or tomorrow. I do not have more detailed information than this.

@emanueleusai
Thank you for signing the PR. It is just more convenient to have this in 12_4 than have it spill over to 12_5 cycle.

Now it's merged. Nice.