Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing minHieraParPerConstr and python3 compatibility for validation … #37961

Merged
merged 1 commit into from
May 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
# AlignmentProducer.ParameterBuilder.Selector, cf. Twiki page SWGuideMillepedeIIAlgorithm.
Presigmas = cms.VPSet(),
minHieraConstrCoeff = cms.double(1.e-10), # min abs value of coeff. in hierarchy constr.
minHieraParPerConstr = cms.uint32(2), # ignore hierarchy constraints with less params
minHieraParPerConstr = cms.uint32(1), # ignore hierarchy constraints with less params
constrPrecision = cms.uint32(10), # precision for writing constraints to text file. Default is 6 and can be setup with constrPrecision = cms.uint32(0)
# specify additional steering files
additionalSteerFiles = cms.vstring(), # obsolete - can be given as entries in 'options'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,10 @@ def plot(MillePedeUser, alignables, mode, struct, parentPlot, config):

# count entries which are not shown anymore
# bin 1 to begin of histogram
for j in range(1, numberOfBins / 2 - binShift):
for j in range(1, numberOfBins // 2 - binShift):
plot.hiddenEntries[i] += plot.histo[i].GetBinContent(j)
# from the end of shown bins to the end of histogram
for j in range(numberOfBins / 2 + binShift, plot.histo[i].GetNbinsX()):
for j in range(numberOfBins // 2 + binShift, plot.histo[i].GetNbinsX()):
plot.hiddenEntries[i] += plot.histo[i].GetBinContent(j)

# merge bins, ca. 100 should be visible in the resulting plot
Expand All @@ -128,8 +128,8 @@ def plot(MillePedeUser, alignables, mode, struct, parentPlot, config):
# set view range. it is important to note that the number of bins have changed with the rebinning
# the total number and the number of shift must be
# corrected with / mergeNumberBins
plot.histo[i].GetXaxis().SetRange(int(numberOfBins / (2 * mergeNumberBins) - binShift /
mergeNumberBins), int(numberOfBins / (2 * mergeNumberBins) + binShift / mergeNumberBins))
plot.histo[i].GetXaxis().SetRange(int(numberOfBins // (2 * mergeNumberBins) - binShift /
mergeNumberBins), int(numberOfBins // (2 * mergeNumberBins) + binShift / mergeNumberBins))

# save copy
plots[subStructNumber] = plot
Expand Down
1 change: 1 addition & 0 deletions Alignment/MillePedeAlignmentAlgorithm/scripts/mps_check.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@
#$mOutSize = `nsls -l $mssDir | grep $milleOut | head -1 | awk '{print \$5}'`;
#$mOutSize = `cmsLs -l $mssDir | grep $milleOut | head -1 | awk '{print \$2}'`;
mOutSize = 0
#print(">>>eoslsoutput:", eoslsoutput, " \ttype(eoslsoutput):", type(eoslsoutput))
for line in eoslsoutput:
if milleOut in line:
columns = line.split()
Expand Down
1 change: 1 addition & 0 deletions Alignment/MillePedeAlignmentAlgorithm/scripts/mps_fire.py
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@ def write_HTCondor_submit_file_mille(path, script, lib, proxy_path=None):
shell=True).decode()
except subprocess.CalledProcessError as e:
result = "" # -> check for successful job submission will fail
#print(' '+result, end=' ')
print(result)
result = result.strip()

Expand Down