Process modifier for 2018 PbPb miniAOD reprocessing

[mandrenguyen]

PR description:

Introduces a process modifier for reprocessing 2018 PbPb miniAOD, as requested by @clacaputo
This PR includes the bugfixes requested in #37907 and #37913, which fix issues in the jet UE subtraction and photon isolation used in heavy ions.

PR validation:

This process modifier is active in workflows 140.5611 (data) and 158.01 (MC)
When activated, this modifier fixes two bugs, one in the jet underlying subtraction, and one in the storing of information needed to redo the photon isolation.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR contains a backport of #36489 and #37262 and is intended for a partial reprocessing of the 2018 PbPb miniAOD, as discussed in #37841

@FHead @ttrk

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for CMSSW_11_2_X.

It involves the following packages:

• Configuration/ProcessModifiers (operations)
• Configuration/PyReleaseValidation (pdmv, upgrade)
• RecoHI/HiJetAlgos (reconstruction)

@perrotta, @jordan-martins, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @missirol, @makortel, @kpedro88, @dgulhan, @Martin-Grunewald, @yslai, @yenjie, @jazzitup, @kurtejung, @trtomei, @beaucero, @slomeo, @yetkinyilmaz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jpata]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abff34/24793/summary.html
COMMIT: c83e365
CMSSW: CMSSW_11_2_X_2022-05-15-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37984/24793/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2537235
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2537206
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 151 log files, 37 edm output root files, 36 DQM output files
• TriggerResults: no differences found

[clacaputo]

Hi @mandrenguyen , thanks for preparing this PR. I would expand it also including #37907.

[mandrenguyen]

@clacaputo Ok, will do

[cmsbuild]

Pull request #37984 was updated. @perrotta, @jordan-martins, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

[cmsbuild]

Pull request #37984 was updated. @perrotta, @jordan-martins, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

[clacaputo]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abff34/24908/summary.html
COMMIT: bbb7362
CMSSW: CMSSW_11_2_X_2022-05-22-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37984/24908/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 46 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2537235
• DQMHistoTests: Total failures: 181
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2537032
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 151 log files, 37 edm output root files, 36 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

@cmsbuild please test
checking if I have the rights :-)

These relval crashes appear to have nothing to do with this PR, and I don't manage to reproduce them interactively. Looks like cvmfs was unavailable or something.

[perrotta]

@cmsbuild please test

[perrotta]

@cmsbuild please test checking if I have the rights :-)

These relval crashes appear to have nothing to do with this PR, and I don't manage to reproduce them interactively. Looks like cvmfs was unavailable or something.

@mandrenguyen I restarted the tests, but yes, those crashes are unrelated from this PR: would they show up again, just ignore them

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abff34/25546/summary.html
COMMIT: 511db8b
CMSSW: CMSSW_11_2_X_2022-06-12-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37984/25546/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 48 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2537235
• DQMHistoTests: Total failures: 180
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2537032
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 151 log files, 37 edm output root files, 36 DQM output files
• TriggerResults: no differences found

[clacaputo]

+reconstruction

• re-sign

[qliphy]

@cms-sw/upgrade-l2 @cms-sw/pdmv-l2 Do you have any comment on this?

[kskovpen]

+pdmv

[srimanob]

+Upgrade

Re-sign

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged.

[qliphy]

@mandrenguyen CMSSW_11_2_5_patch2 is now ready https://cms-talk.web.cern.ch/t/patched-production-release-cmssw-11-2-5-patch2-now-available/11940