Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the naming convention of CaloMETs #3801

Closed
wants to merge 31 commits into from

Conversation

TaiSakuma
Copy link
Contributor

This PR changes the naming convention of CaloMETs. In particular, this PR

  • renames met caloMet
  • renames metNoHF caloMetBE
  • renames metHO caloMetBEFO
  • renames metNoHFHO caloMetBEO

caloMet, caloMetBE, caloMetBEFO are event contents of RECO and AOD.

We announced this change at the JMAR meeting on 24-Apr-2014:
https://indico.cern.ch/event/304145/contribution/0

We discussed this change at the RECO meeting on 17-Apr-2014: https://indico.cern.ch/event/313948/contribution/18

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_7_1_X.

change the naming convention of CaloMETs

It involves the following packages:

HLTriggerOffline/Higgs
HLTriggerOffline/SUSYBSM
RecoMET/Configuration
RecoMET/METProducers

@thspeer, @danduggan, @rovere, @cmsbuild, @anton-a, @nclopezo, @deguio, @slava77, @Degano, @ojeda can you please review it and eventually sign? Thanks.
@nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
I ran the usual tests and I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3801/1432/summary.html

@cmsbuild
Copy link
Contributor

Pull request #3801 was updated. @thspeer, @danduggan, @rovere, @cmsbuild, @anton-a, @nclopezo, @deguio, @slava77, @Degano, @ojeda can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

-1
I ran the usual tests and I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3801/1441/summary.html

@TaiSakuma
Copy link
Contributor Author

I updated this PR as we disscussed at #3938.
I also rebased onto 7_1_X.

@cmsbuild
Copy link
Contributor

Pull request #3801 was updated. @ojeda, @danduggan, @rovere, @monttj, @cmsbuild, @anton-a, @thspeer, @deguio, @slava77, @vadler, @Degano, @nclopezo can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented May 20, 2014

71X is now closed for new features.
Do we really need this change in 71X?
Tai, can we just proceed to having it in 72X?

@vadler
Copy link

vadler commented May 20, 2014

@TaiSakuma : Ah, I'm very, very sorry, but I think I made a mistake here :-( I got confused by other cases, where changes in the event content hit future intagration of PAT work flows into RelVal production with cmsDriver.py (s. #3936 ).
The proper solution would be to comment that line in PhysicsTools/PatAlgos/test/patTuple_addJets_cfg.py rather than changing it until we base the PAT tests on the new event content.
Again, I'm very sorry for the additional work.

@TaiSakuma
Copy link
Contributor Author

@slava77, it doesn't have to be 71X. I will make a PR for 72X.

@TaiSakuma
Copy link
Contributor Author

@vadler, that is fine. I will comment out the line in new PR for 72X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants