Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename phase1_2021* to phase1_2022* #38252

Merged
merged 1 commit into from Jun 7, 2022
Merged

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Jun 5, 2022

PR description:

After the "ATTF / O+C / PPD / XPOG Meeting" (https://indico.cern.ch/event/1167839/) we realized that from 12_4_X many people will use the Run-3 GTs, and the naming convention that phase1_2021* is meant to be used for 2022 will be confusing for many people. This PR does a purely technical change of renaming that.

The diffs in the GTs are null:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, but should be backported to 12_4_X

@tvami
Copy link
Contributor Author

tvami commented Jun 5, 2022

test parameters:

  • full = true

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38252/30401

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2022

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Alignment/MuonAlignment (alca)
  • Alignment/SurveyAnalysis (alca)
  • Configuration/AlCa (alca)
  • Configuration/HLT (hlt)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • DPGAnalysis/Skims (pdmv)
  • DQM/GEM (dqm)
  • DQM/TrackerRemapper (dqm)
  • EventFilter/CSCRawToDigi (reconstruction)
  • EventFilter/CTPPSRawToDigi (reconstruction)
  • EventFilter/GEMRawToDigi (reconstruction)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/HcalCommonData (geometry)
  • Geometry/HcalTowerAlgo (geometry)
  • Geometry/TrackerCommonData (geometry)
  • Geometry/VeryForwardData (geometry)
  • L1Trigger/CSCTriggerPrimitives (l1)
  • RecoLocalCalo/EcalRecProducers (reconstruction)
  • RecoParticleFlow/PFProducer (reconstruction)
  • RecoTracker/MkFit (reconstruction)
  • SimG4CMS/Calo (simulation)
  • SimG4CMS/Forward (simulation)
  • SimG4CMS/Muon (simulation)
  • SimG4CMS/ShowerLibraryProducer (simulation)
  • SimG4Core/Configuration (simulation)
  • SimG4Core/PhysicsLists (simulation)
  • SimG4Core/PrintGeomInfo (simulation)
  • SimMuon/RPCDigitizer (simulation)
  • SimPPS/Configuration (simulation)
  • SimTracker/TrackerMaterialAnalysis (simulation)
  • Validation/CSCRecHits (dqm)
  • Validation/Geometry (geometry, dqm)
  • Validation/MuonCSCDigis (dqm)
  • Validation/RecoParticleFlow (dqm)

@bbilin, @ianna, @Martin-Grunewald, @rekovic, @cecilecaillol, @civanch, @yuanchao, @makortel, @ahmad3213, @cmsbuild, @missirol, @pmandrik, @Dr15Jones, @epalencia, @cvuosalo, @emanueleusai, @mdhildreth, @AdrianoDee, @jfernan2, @kskovpen, @slava77, @jpata, @micsucmed, @francescobrivio, @malbouis, @jordan-martins, @clacaputo, @srimanob, @tvami, @rvenditti can you please review it and eventually sign? Thanks.
@grzanka, @felicepantaleo, @hatakeyamak, @CeliaFernandez, @ghugo83, @jshlee, @bsunanda, @eyigitba, @fioriNTU, @thomreis, @tlampen, @trtomei, @rishabhCMS, @threus, @mmusich, @seemasharmafnal, @venturia, @pakhotin, @mmarionncern, @hdelanno, @vargasa, @makortel, @JanFSchulte, @jhgoh, @dgulhan, @valuev, @apsallid, @slomeo, @simonepigazzini, @trocino, @lgray, @kpedro88, @giovanni-mocellin, @abbiendi, @barvic, @cvuosalo, @fabferro, @GiacomoSguazzoni, @tocheng, @VinInn, @missirol, @ptcox, @rovere, @jandrea, @idebruyn, @ebrondol, @argiro, @mtosi, @fabiocos, @rbartek, @Martin-Grunewald, @adewit, @rchatter, @beaucero, @silviodonato, @lecriste, @gpetruc, @watson-ij this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Jun 5, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5c960a/25290/summary.html
COMMIT: d8b596d
CMSSW: CMSSW_12_5_X_2022-06-05-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38252/25290/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test DetectorDescriptionDDCMSTestDriver had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3651603
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3651579
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

missirol commented Jun 7, 2022

+hlt

@jpata
Copy link
Contributor

jpata commented Jun 7, 2022

+reconstruction

  • technical renaming of GTs
  • no reco changes (most of the code changes are in /test/, so it's possible private codes may have to take note of this change)

@cecilecaillol
Copy link
Contributor

+l1

@srimanob
Copy link
Contributor

srimanob commented Jun 7, 2022

+Upgrade

Technical PR to change phase1_2021 to phase2_2022. No change is expected.

@civanch
Copy link
Contributor

civanch commented Jun 7, 2022

+1

@kskovpen
Copy link
Contributor

kskovpen commented Jun 7, 2022

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 7, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet