Fix ThroughputServiceClient.cc unsigned variables overflow

[pmandrik]

PR description:

TH1F FindFirstBinAbove() can return -1 [0] when hist is empty overflowing unsigned variables uint64_t first and uint64_t last. The next two loops for (unsigned int i = first; i <= last; ++i) became very long and hlt_clientPB DQM client is not able to exit in time when the run is ended. Affect Online DQM operation.

[0] https://root.cern.ch/doc/master/classTH1.html#a63960594f84aea92e5fa2d5129b49007

PR validation:

Tested at P5 DQM playback.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38282/30433

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @pmandrik for master.

It involves the following packages:

• HLTrigger/Timer (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Martin-Grunewald]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a2472/25362/summary.html
COMMIT: 615e245
CMSSW: CMSSW_12_5_X_2022-06-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38282/25362/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3652078
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3652048
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[Martin-Grunewald]

@pmandrik
I assume a backport to 12_4 is required. Could you please provide one? Thanks!

[qliphy]

+1

[missirol]

type bugfix