Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HGCal config changes required for #3790 #3839

Merged
merged 8 commits into from May 14, 2014

Conversation

mark-grimes
Copy link

This request includes #3790 from @pfs. The only changes on top of that are to Configuration/PyReleaseValidation/python/relval_steps.py and SLHCUpgradeSimulations/Configuration/python/combinedCustoms.py.

The changes are for extra configuration for the HGCal digitisation suggested by @pfs.

@pfs
Copy link
Contributor

pfs commented May 13, 2014

thank you!

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

HGCal config changes required for #3790

It involves the following packages:

Configuration/PyReleaseValidation
DataFormats/HGCDigi
RecoLocalCalo/HGCalRecProducers
SLHCUpgradeSimulations/Configuration
SimCalorimetry/Configuration
SimCalorimetry/HGCSimProducers
SimGeneral/MixingModule

The following packages do not have a category, yet:

DataFormats/HGCDigi
RecoLocalCalo/HGCalRecProducers
SimCalorimetry/HGCSimProducers

@civanch, @nclopezo, @vlimant, @mdhildreth, @cmsbuild, @franzoni, @Degano, @ktf, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

merge

Even with these changes I'm still getting the same failures.
Tests 10000, 10200, 10400, 11200, 11400, 12000, 12800, 13000, 13600 and 14600 pass all steps.
Tests 12400, 12600, 13800 and 14000 fail in step 2 with known errors.
Tests 12200, 14200 and 14400 fail in step 3 with known errors.

cmsbuild added a commit that referenced this pull request May 14, 2014
@cmsbuild cmsbuild merged commit b149b63 into cms-sw:CMSSW_6_2_X_SLHC May 14, 2014
@mark-grimes mark-grimes deleted the fixHGCalConfig branch August 3, 2015 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants