Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation warnings #3845

Merged
merged 1 commit into from May 13, 2014
Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented May 13, 2014

Fix compilation warnings in ROOT6 build coming from compilation of dictionaries. All the warnings are from the same header:
CondFormats/Serialization/interface/eos/portable_oarchive.hpp:324:15: warning: shift count >= width of type [-Wshift-count-overflow]
The warnings are fixed by special casing calculating the size of single byte types. Single byte types cause the warning because the shift count of 8 is >= 8(the size of the type in bits).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_1_ROOT6_X.

Fix compilation warnings

It involves the following packages:

CondFormats/Serialization

@ggovi, @cmsbuild, @apfeiffer1, @Degano, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

ktf added a commit that referenced this pull request May 13, 2014
@ktf ktf merged commit 5f99bad into cms-sw:CMSSW_7_1_ROOT6_X May 13, 2014
@wmtan wmtan deleted the FixCompilationWarnings branch June 3, 2014 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants