Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X]Update HLT GT with ECAL DQM tower and channel status tags #38456

Merged
merged 1 commit into from Jun 24, 2022

Conversation

malbouis
Copy link
Contributor

PR description:

backport of #38455

This PR is mainly to include Ecal DQM channel and tower status in the HLT (and HLT_relval) GTs, needed in PR #38357 + backports.

The Ecal tags to be included in HLT GT are: EcalDQMChannelStatus_v1_hlt and EcalDQMTowerStatus_v1_hlt.

We also take the chance to include the PPS optical function tag, that had already been included in the Express and Prompt GTs for P5 operations: PPSOpticalFunctions_hlt_v9

All three tags were include in HLT and HLT_relval GTs.

The differences wrt to the previous GTs are shown below:
run3_hlt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_HLT_frozen_v2/124X_dataRun3_HLT_frozen_v3

run3_hlt_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_HLT_relval_v3/124X_dataRun3_HLT_relval_v5

We also took care that there are no differences other than the L1 menus between the frozen and relval GTs:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_HLT_relval_v5/124X_dataRun3_HLT_frozen_v3

PR validation:

nohup runTheMatrix.py -l 139.001 --ibeos -j16

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #38455

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 21, 2022

A new Pull Request was created by @malbouis for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @Martin-Grunewald, @missirol, @mmusich, @ChrisMisan, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jun 21, 2022

backport of #38455

@tvami
Copy link
Contributor

tvami commented Jun 21, 2022

type ecal

@cmsbuild
Copy link
Contributor

Pull request #38456 was updated. @malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #38456 was updated. @cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

@malbouis malbouis force-pushed the alca-updateHLTGTs_ECAL-124X branch from 121ad9c to 643dca0 Compare June 21, 2022 22:02
@cmsbuild
Copy link
Contributor

Pull request #38456 was updated. @cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

@malbouis
Copy link
Contributor Author

please test

@malbouis malbouis changed the title Update HLT GT with ECAL DQM tower and channel status tags [12_4_X]Update HLT GT with ECAL DQM tower and channel status tags Jun 21, 2022
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bef46a/25677/summary.html
COMMIT: 643dca0
CMSSW: CMSSW_12_4_X_2022-06-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38456/25677/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bef46a/25677/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bef46a/25677/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3680359
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3680329
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jun 22, 2022

+alca

  • changes are according to the PR description
  • tests pass
  • failures are in MsgLogger and MTD only

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 24, 2022

+1

@cmsbuild cmsbuild merged commit 57a1050 into cms-sw:CMSSW_12_4_X Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants