Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for edm::FwdRef #3851

Merged
merged 1 commit into from
May 20, 2014
Merged

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented May 14, 2014

@gpetruc @rappoccio
Fix FwdRef so that at get() time it checks Availability rather than Nullness.
Should fix the access when the original collection is kept and the forward pointed is dropped.
This way should also be complaint with the implementation of edm::FwdRef::isAvailable that return true if any of the two collections is available. With old implementation despite isAvailable being true, dereferencing would throw if the fwd pointed was dropped.

See:
https://hypernews.cern.ch/HyperNews/CMS/get/edmFramework/3282.html

Similar to PR #3850

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arizzi for CMSSW_7_0_X.

FwdRef and FwdPtr: Nullness and Availability are two different things

It involves the following packages:

DataFormats/Common

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@arizzi arizzi changed the title FwdRef and FwdPtr: Nullness and Availability are two different things Bugfix for edm::FwdRef May 14, 2014
@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented May 20, 2014

Approved at today ORP. Merging.

ktf added a commit that referenced this pull request May 20, 2014
@ktf ktf merged commit d3515c5 into cms-sw:CMSSW_7_0_X May 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants