Jet met DQM and Validation code

[deguio]

this PR supersedes #3856 and #3855

@sordini @webermat
please have a look and shout if you are not ok with this.

[cmsbuild]

A new Pull Request was created by @deguio for CMSSW_7_1_X.

Jet met DQM and Validation code

It involves the following packages:

DQMOffline/JetMET
Validation/RecoJets
Validation/RecoMET

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[webermat]

for the comment if the empty client, we know it is empty. We tried to remove the client previously and remove it from the sequence, but then the HI sequence crashed.

https://github.com/cms-sw/cmssw/blob/CMSSW_7_1_X/DQMOffline/Configuration/python/DQMOfflineHeavyIons_Certification_cff.py

line 7 -> which puts it actually on ignore (which would be done anyway if removed from the sequence)
DQMOfflineHeavyIons_Certification.remove(jetMETDQMOfflineClient)

Unfortunately when i went through all files in our folder, and the DQM store is called in other files too, see e.g.
https://github.com/JetMETdqmval/cmssw/blob/develop_DQMHarvest_7_1_0_pre7/DQMOffline/JetMET/src/CaloTowerAnalyzer.cc

where everything which calls the DQMStore in dqmbeginRun should be moved to bookHistograms
i suppose. For the rest it just needs removal then.

[deguio]

yes. I agree with both your points.

[cmsbuild]

Pull request #3861 was updated. @civanch, @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @mdhildreth, @deguio, @Degano can you please check and sign again.

[deguio]

@webermat have a look at the last commit. this should address both the issues.

[webermat]

in HTMHT we have a direct call of the DQMStore (but that one is never used, and I think the beginJob is not even per default called)

void HTMHTAnalyzer::beginJob(DQMStore * dbe) {
}

then in SUSYDQMAnalyzer constructor we call the DQMStore (and it is not used later on)
dqm = edm::Service().operator->();

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3861/1516/summary.html

[cmsbuild]

Pull request #3861 was updated. @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please check and sign again.

[cmsbuild]

-1
When I ran the RelVals I found an error in the following worklfows:
1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3861/1533/summary.html

[deguio]

is this related? seems to me that the needed files are not found.
F.

[webermat]

the only point could be that the JetMETDQMOfflineClient is still called in one of the sequences for certification (e.g. in this version of pre7 it would have been called in file)
https://github.com/cms-sw/cmssw/blob/CMSSW_7_1_X/DQMOffline/JetMET/python/dataCertificationJetMET_cff.py

which now should be

import FWCore.ParameterSet.Config as cms

from DQMOffline.JetMET.dataCertificationJetMET_cfi import *

dataCertificationJetMETSequence = cms.Sequence(qTesterJet + qTesterMET + dataCertificationJetMET)

after removal of the JetMETDQMOfflineClient

[deguio]

@webermat
it is as you suggest already. see https://github.com/deguio/cmssw/blob/JetMet/DQMOffline/JetMET/python/dataCertificationJetMET_cff.py

[deguio]

@webermat
have a look here
F.

[deguio]

it seems to me that the das query returns 0 files.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3861/1550/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3861/1550/summary.html