Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix db_tree_dump_wrapper for unit test usage #38657

Merged
merged 1 commit into from Jul 9, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 8, 2022

PR description:

I casually noticed in the cmssw dashboard that CondTools/SiStrip is silently failing because the db_tree_dump_wrapper.py script cannot find locally the cmsRun executable configuration, see log
This PR fixes the issue and also changes the execme method in order to raise a python error instead of silently failing.

PR validation:

Run successfully scram b runtests with this package

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38657/30940

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2022

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CondTools/SiStrip (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jul 8, 2022

@cmsbuild , please test

@tvami
Copy link
Contributor

tvami commented Jul 8, 2022

type bugfix,trk

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7205e1/26088/summary.html
COMMIT: bea9b63
CMSSW: CMSSW_12_5_X_2022-07-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38657/26088/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test SiStripDAQ_O2O_test had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3655935
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3655893
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Jul 9, 2022

---> test SiStripDAQ_O2O_test had ERRORS

Failure is unrelated. That test is also randomly failing in IBs (see log)

@tvami
Copy link
Contributor

tvami commented Jul 9, 2022

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jul 9, 2022

+1

@perrotta
Copy link
Contributor

perrotta commented Jul 9, 2022

merge

@cmsbuild cmsbuild merged commit 36b0a36 into cms-sw:master Jul 9, 2022
@mmusich mmusich deleted the fixCondToolsSiStripUnitTest_12_5_X branch July 9, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants