-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix db_tree_dump_wrapper
for unit test usage
#38657
fix db_tree_dump_wrapper
for unit test usage
#38657
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38657/30940
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
type bugfix,trk |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test SiStripDAQ_O2O_test had ERRORS Comparison SummarySummary:
|
Failure is unrelated. That test is also randomly failing in IBs (see log) |
+db
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge |
PR description:
I casually noticed in the cmssw dashboard that
CondTools/SiStrip
is silently failing because thedb_tree_dump_wrapper.py
script cannot find locally the cmsRun executable configuration, see logThis PR fixes the issue and also changes the
execme
method in order toraise
a python error instead of silently failing.PR validation:
Run successfully
scram b runtests
with this packageIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A