Make SiStripClusterizer prods stream modules #3866
Conversation
The ClustersFromRawProducer puts a helper it owns into the DetSetVector so it is necessary for this module to be a stream module so each Event gets its own helper. This avoids problems in the threaded framework when multiple Events are being processed. This code will have to be revisited when we start to use multiple threads for one Event.
We believe it is safe to convert this to a stream module to allow efficient processing when using multiple threads.
|
@ktf this should fix many of the failures in the THREADED IB |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X. Make SiStripClusterizer prods stream modules It involves the following packages: RecoLocalTracker/SiStripClusterizer @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks. |
…eamModules Multithreading -- Make SiStripClusterizer prods stream modules
Needed to convert ClustersFromRawProducer to a stream module so that we get a unique lazy filler of DetSetVector for each stream. This avoids threading problems when running with multiple events. It also makes the threading jobs more efficient.
Also converted SiStripClusterToDigiProducer to stream since it appears to be safe to do so (static analyzer gives it a clean bill of health).