[12_4_X] Run3 GEMGeometryBuilder Run3 modifier and fix DQM GEM chambers #38694

francescobrivio · 2022-07-11T21:54:39Z

PR description:

Backport of #38666 and #38908:

GEM Run3 modifier setup for the alignment.
Fix the geometry information of GEM chambers in DQM.

@hyunyong @jshlee @watson-ij @quark2 since we are very tight with times I took the liberty of opening the backport, it is a verbatim copy of @hyunyong's and @quark2's master PRs.

PR validation:

Code compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38666 and #38908

francescobrivio · 2022-07-11T21:54:56Z

backport of #38666

cmsbuild · 2022-07-11T21:54:58Z

A new Pull Request was created by @francescobrivio for CMSSW_12_4_X.

It involves the following packages:

Geometry/GEMGeometryBuilder (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@giovanni-mocellin, @watson-ij, @fabiocos, @jshlee, @bsunanda, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

Backported from Run3 GEMGeometryBuilder Run3 modifier #38666

francescobrivio · 2022-07-11T21:55:50Z

test parameters:

pull_request = [12_4_X] Add GEM alignment in all Run3 GTs #38693

francescobrivio · 2022-07-11T21:57:11Z

@cmsbuild please test

francescobrivio · 2022-07-11T21:59:32Z

type gem

cmsbuild · 2022-07-12T00:19:11Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84e70a/26151/summary.html
COMMIT: 8b6337b
CMSSW: CMSSW_12_4_X_2022-07-11-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38694/26151/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-beam_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-mutracking_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-pixel_dqm_sourceclient had ERRORS

RelVals

39500.0

----- Begin Fatal Exception 12-Jul-2022 00:52:11 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Calling method for module GEMDigiProducer/'simMuonGEMDigis'
   [1] Calling method for EventSetup module GEMGeometryESModule/'gemGeometry'
   [2] While getting dependent Record from Record MuonGeometryRecord
Exception Message:
No "GEMAlignmentRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

23234.0

----- Begin Fatal Exception 12-Jul-2022 00:52:11 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Calling method for module GEMDigiProducer/'simMuonGEMDigis'
   [1] Calling method for EventSetup module GEMGeometryESModule/'gemGeometry'
   [2] While getting dependent Record from Record MuonGeometryRecord
Exception Message:
No "GEMAlignmentRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

39496.0

----- Begin Fatal Exception 12-Jul-2022 00:52:13 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Calling method for module GEMDigiProducer/'simMuonGEMDigis'
   [1] Calling method for EventSetup module GEMGeometryESModule/'gemGeometry'
   [2] While getting dependent Record from Record MuonGeometryRecord
Exception Message:
No "GEMAlignmentRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

23234.2123234.21_TTbar_14TeV+2026D49_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+MiniAOD/step2_TTbar_14TeV+2026D49_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+MiniAOD.log
23234.023234.0_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal.log
23434.2123434.21_TTbar_14TeV+2026D49PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU/step2_TTbar_14TeV+2026D49PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU.log

Expand to see more relval errors ...

cmsbuild · 2022-07-12T13:25:26Z

Pull request #38694 was updated. @civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

francescobrivio · 2022-07-12T13:27:14Z

@cmsbuild please test

cmsbuild · 2022-07-12T19:05:07Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84e70a/26168/summary.html
COMMIT: 0602e19
CMSSW: CMSSW_12_4_X_2022-07-12-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38694/26168/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-beam_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-mutracking_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-pixel_dqm_sourceclient had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 20893 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3676111
DQMHistoTests: Total failures: 57960
DQMHistoTests: Total nulls: 5
DQMHistoTests: Total successes: 3618124
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 2.25 KiB( 49 files compared)
DQMHistoSizes: changed ( 11834.0 ): 2.250 KiB SiStrip/MechanicalView
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: found differences in 7 / 49 workflows

francescobrivio · 2022-08-08T13:33:14Z

Test are now successful.
@hyunyong @quark2 @jshlee @watson-ij please clarify the urgency of this PR (or if it is needed at all in 12_4_X...)

quark2 · 2022-08-08T17:47:17Z

Hi @francescobrivio,

I think the fix of the GEM onlineDQM is well-propagated.

Best regards,
Byeonghak Ko

bsunanda · 2022-08-08T18:19:53Z

+geometry

emanueleusai · 2022-08-16T15:29:42Z

+dqm

srimanob · 2022-08-22T07:12:50Z

+Upgrade

cmsbuild · 2022-08-22T07:13:14Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-08-22T09:59:33Z

please test
(18 days old tests need to be refreshed)

perrotta · 2022-08-22T10:02:18Z

This is a verbatim backport of #38666 and #38908 (note for the release managers)

cmsbuild · 2022-08-22T14:15:39Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84e70a/26973/summary.html
COMMIT: a7d1a5c
CMSSW: CMSSW_12_4_X_2022-08-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38694/26973/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3677242
DQMHistoTests: Total failures: 10
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3677210
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

perrotta · 2022-08-22T14:31:58Z

+1

Run3 GEMGeometryBuilder alignment modifier

8b6337b

cmsbuild added this to the CMSSW_12_4_X milestone Jul 11, 2022

cmsbuild added geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Jul 11, 2022

cmsbuild added the backport label Jul 11, 2022

cmsbuild added the requires-external label Jul 11, 2022

francescobrivio mentioned this pull request Jul 11, 2022

[12_4_X] Add GEM alignment in all Run3 GTs #38693

Merged

cmsbuild added tests-started and removed tests-pending labels Jul 11, 2022

cmsbuild added the gem label Jul 11, 2022

cmsbuild added tests-rejected and removed tests-started labels Jul 12, 2022

applyAlignment = False for phase2

0602e19

cmsbuild added tests-pending and removed tests-rejected labels Jul 12, 2022

cmsbuild added tests-started and removed tests-pending labels Jul 12, 2022

cmsbuild removed the tests-started label Jul 12, 2022

cmsbuild added the tests-approved label Aug 4, 2022

quark2 mentioned this pull request Aug 8, 2022

Fixed codes which causes memory issue by GEM onlineDQM, a backport to 12_4_X #38998

Closed

cmsbuild added geometry-approved and removed geometry-pending labels Aug 8, 2022

cmsbuild added dqm-approved backport-ok and removed dqm-pending backport labels Aug 16, 2022

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Aug 22, 2022

cmsbuild added tests-started and removed tests-approved labels Aug 22, 2022

cmsbuild added tests-approved and removed tests-started labels Aug 22, 2022

cmsbuild added orp-approved and removed orp-pending labels Aug 22, 2022

cmsbuild merged commit b46958c into cms-sw:CMSSW_12_4_X Aug 22, 2022

francescobrivio deleted the alca-activateGEMalignment_12_4_X branch August 29, 2022 12:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12_4_X] Run3 GEMGeometryBuilder Run3 modifier and fix DQM GEM chambers #38694

[12_4_X] Run3 GEMGeometryBuilder Run3 modifier and fix DQM GEM chambers #38694

francescobrivio commented Jul 11, 2022 •

edited

francescobrivio commented Jul 11, 2022

cmsbuild commented Jul 11, 2022 •

edited

francescobrivio commented Jul 11, 2022

francescobrivio commented Jul 11, 2022

francescobrivio commented Jul 11, 2022

cmsbuild commented Jul 12, 2022

cmsbuild commented Jul 12, 2022

francescobrivio commented Jul 12, 2022

cmsbuild commented Jul 12, 2022

francescobrivio commented Aug 8, 2022

quark2 commented Aug 8, 2022

bsunanda commented Aug 8, 2022

emanueleusai commented Aug 16, 2022

srimanob commented Aug 22, 2022

cmsbuild commented Aug 22, 2022

perrotta commented Aug 22, 2022

perrotta commented Aug 22, 2022

cmsbuild commented Aug 22, 2022

perrotta commented Aug 22, 2022

[12_4_X] Run3 GEMGeometryBuilder Run3 modifier and fix DQM GEM chambers #38694

[12_4_X] Run3 GEMGeometryBuilder Run3 modifier and fix DQM GEM chambers #38694

Conversation

francescobrivio commented Jul 11, 2022 • edited

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

francescobrivio commented Jul 11, 2022

cmsbuild commented Jul 11, 2022 • edited

francescobrivio commented Jul 11, 2022

francescobrivio commented Jul 11, 2022

francescobrivio commented Jul 11, 2022

cmsbuild commented Jul 12, 2022

Unit Tests

RelVals

RelVals-INPUT

cmsbuild commented Jul 12, 2022

francescobrivio commented Jul 12, 2022

cmsbuild commented Jul 12, 2022

Unit Tests

Comparison Summary

francescobrivio commented Aug 8, 2022

quark2 commented Aug 8, 2022

bsunanda commented Aug 8, 2022

emanueleusai commented Aug 16, 2022

srimanob commented Aug 22, 2022

cmsbuild commented Aug 22, 2022

perrotta commented Aug 22, 2022

perrotta commented Aug 22, 2022

cmsbuild commented Aug 22, 2022

Comparison Summary

perrotta commented Aug 22, 2022

francescobrivio commented Jul 11, 2022 •

edited

cmsbuild commented Jul 11, 2022 •

edited