Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiPixelLorentzAnglePCLHarvester: fetch precise B-field value from map via inverseBzAtOriginInGeV #38700

Merged
merged 1 commit into from Jul 12, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 12, 2022

PR description:

The primary goal of this PR is to address the second point of issue #38669:

Unrelated to the crash, but pixel people beware: using magField->nominalValue() as a physical value as in https://github.com/cms-sw/cmssw/pull/38653/files#diff-cd4b91b1150cb8ea3ac6cdb24d49a6bd99f77a8320a5d4a60eeab3000ff42eb1R141 is not a good idea. nominalValue() is intended to be used as a label, and is truncated to int, with the corresponding loss of accuracy.
The method inverseBzAtOriginInGeV() was added to the interface for the benefit of pixel code (#35081), for example.

This is done by taking the value of the magnetic field from inverseBzAtOriginInGeV() (after having converted it from [GeV-1] to [T]) instead of nominalValue().
I profit of this PR to rename all the other member variable to follow the code rule pattern (rule 2.9: https://cms-sw.github.io/cms_coding_rules.html)

PR validation:

Tested successfully the multi-run harvesting mode recipe at #38641 (comment);

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but a backport to CMSSW_12_4_X is needed.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38700/30996

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CalibTracker/SiPixelLorentzAngle (alca)

@malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@tocheng, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jul 12, 2022

There is a few lines of commented out code, that should be removed, but besides that it looks good to me, thanks @mmusich !

@mmusich
Copy link
Contributor Author

mmusich commented Jul 12, 2022

There is a few lines of commented out code, that should be removed,

why? they are you know.. a comment...

@tvami
Copy link
Contributor

tvami commented Jul 12, 2022

why? they are you know.. a comment...

Ok, ignore my comment, I was reading through the code too quickly

@tvami
Copy link
Contributor

tvami commented Jul 12, 2022

type bugfix,trk

@mmusich
Copy link
Contributor Author

mmusich commented Jul 12, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8376ff/26160/summary.html
COMMIT: 7467baa
CMSSW: CMSSW_12_5_X_2022-07-11-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38700/26160/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3655970
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3655934
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jul 12, 2022

+alca

  • PR is according to the description
  • Jenkins test pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bf84f5a into cms-sw:master Jul 12, 2022
@mmusich mmusich deleted the fixMagneticFieldSiPixelLorentzAngle branch July 12, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants