New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SiPixelLorentzAnglePCLHarvester
: fetch precise B-field value from map via inverseBzAtOriginInGeV
#38700
SiPixelLorentzAnglePCLHarvester
: fetch precise B-field value from map via inverseBzAtOriginInGeV
#38700
Conversation
… via inverseBzAtOriginInGeV
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38700/30996
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
There is a few lines of commented out code, that should be removed, but besides that it looks good to me, thanks @mmusich ! |
why? they are you know.. a comment... |
Ok, ignore my comment, I was reading through the code too quickly |
type bugfix,trk |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8376ff/26160/summary.html Comparison SummarySummary:
|
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The primary goal of this PR is to address the second point of issue #38669:
This is done by taking the value of the magnetic field from
inverseBzAtOriginInGeV()
(after having converted it from [GeV-1] to [T]) instead ofnominalValue()
.I profit of this PR to rename all the other member variable to follow the code rule pattern (rule 2.9: https://cms-sw.github.io/cms_coding_rules.html)
PR validation:
Tested successfully the multi-run harvesting mode recipe at #38641 (comment);
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but a backport to CMSSW_12_4_X is needed.