HCAL: Bugfix of PFA1' Trigger Primitive algo by switching to integer based math

[Michael-Krohn]

PR description:

Switching from double variable based math to integer variable based math in the TP energy algorithm. This is to match what is in the firmware on detector. Also, the logic blocks to perform the energy calculation for PFA1' and PFA2 have been separated. Again to match what is in the firmware on detector.

PR validation:

A basic technical test was performed: runTheMatrix.py -l limited -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38753/31073

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38753/31073/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38753/31073/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38753/31074

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38753/31074/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38753/31074/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38753/31076

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @Michael-Krohn for master.

It involves the following packages:

• SimCalorimetry/HcalTrigPrimAlgos (l1)
• SimCalorimetry/HcalTrigPrimProducers (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@bsunanda, @abdoulline, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-183c76/26283/summary.html
COMMIT: 78bac75
CMSSW: CMSSW_12_5_X_2022-07-16-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38753/26283/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3654053
• DQMHistoTests: Total failures: 1100
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3652931
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: found differences in 2 / 49 workflows

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38753/31198

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #38753 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-183c76/26386/summary.html
COMMIT: 8414339
CMSSW: CMSSW_12_5_X_2022-07-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38753/26386/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-183c76/13234.0_TTbar_14TeV+2021FS+TTbar_14TeV_TuneCP5_FastSimRun3+HARVESTFastRun3
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-183c76/13434.0_TTbar_14TeV+2021FSPU+TTbar_14TeV_TuneCP5_FastSimRun3PU+HARVESTFastRun3PU

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3706484
• DQMHistoTests: Total failures: 562
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3705900
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 210 log files, 47 edm output root files, 51 DQM output files
• TriggerResults: found differences in 2 / 50 workflows

[perrotta]

@cms-sw/l1-l2 could you please check and (re)sign, if you agree with the latest changes?

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1