Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BeamSpot in Run3 MC GTs + swap Run3RoundOptics25ns13TeVLowSigmaZ with Realistic25ns13p6TeVEarly2022Collision vtx smearing #38760

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 15, 2022

PR description:

PR #38692 changed the default Beam Spot in the Run-3 Global Tag , but it was thn now out-of-synch with the vertex smearing assumed for the Run-3 RelVal workflows, even if it is correct for the 2022 physics MC.
This PR fixes the problem by making Realistic25ns13p6TeVEarly2022Collision the default for Run-3 relval workflows and wherever it is necessary to change it in standalone configurations together with the BeamSpot updates in the Run-3 MC GlobalTags.
In this PR we add:

The new BeamSpot tags are:

  • BeamSpotObjects_Realistic25ns_13p6TeVCollisions_Early2022_v3_mc
  • BeamSpotOnlineObjects_Realistic25ns_13p6TeVCollisions_Early2022_v2_mc

The GT diffs are:

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

to be backported together with other updates to 12.4.X

cc:
@cms-sw/alca-l2

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38760/31084

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • EventFilter/CSCRawToDigi (reconstruction)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/HcalCommonData (geometry)
  • Geometry/TrackerCommonData (geometry)
  • Geometry/VeryForwardData (geometry)
  • SimG4CMS/Calo (simulation)
  • SimG4CMS/ShowerLibraryProducer (simulation)
  • SimG4Core/Configuration (simulation)

@civanch, @Dr15Jones, @jordan-martins, @bsunanda, @makortel, @bbilin, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @clacaputo, @kskovpen, @jpata can you please review it and eventually sign? Thanks.
@thomreis, @felicepantaleo, @kpedro88, @ghugo83, @Martin-Grunewald, @bsunanda, @grzanka, @trtomei, @slomeo, @venturia, @vargasa, @makortel, @JanFSchulte, @missirol, @simonepigazzini, @beaucero, @barvic, @fabferro, @rovere, @VinInn, @ptcox, @mmusich, @mtosi, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jul 15, 2022

please test

@perrotta
Copy link
Contributor

@mmusich I have prepared the revert of #38692 in #38762
Since I doubt you'll be able to collect all needed signatures by this evening, let me revert that PR now: you can add the new GTs in this PR of yours, so that all changes can be merged together

@perrotta
Copy link
Contributor

@mmusich @francescobrivio please add back here the commit from #38692 that was reverted in the master, see #38762 (comment)

@mmusich
Copy link
Contributor Author

mmusich commented Jul 15, 2022

please add back here the commit from #38692 that was reverted in the master, see #38762 (comment)

done.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38760/31089

@srimanob
Copy link
Contributor

+Upgrade

#39041 is OK now.

@tvami
Copy link
Contributor

tvami commented Aug 25, 2022

@cms-sw/simulation-l2 can you please re-sign?

@mmusich
Copy link
Contributor Author

mmusich commented Aug 25, 2022

test parameters:

@mmusich
Copy link
Contributor Author

mmusich commented Aug 25, 2022

@cmsbuild, please test

@civanch
Copy link
Contributor

civanch commented Aug 25, 2022

+1

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b625f/27074/summary.html
COMMIT: d7e814e
CMSSW: CMSSW_12_5_X_2022-08-24-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38760/27074/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 18500 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3693084
  • DQMHistoTests: Total failures: 94326
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3598734
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.007 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 3.011 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 8 / 50 workflows

@mmusich
Copy link
Contributor Author

mmusich commented Aug 25, 2022

unhold

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Aug 25, 2022

on a side note, it's sad that issue #38980 is not solved yet, as it would have been good to check the differences in more detail at https://tinyurl.com/2jkb6wmw

@mmusich
Copy link
Contributor Author

mmusich commented Aug 25, 2022

some observations from the relmon for wf 11834.0 (TTBar 2021, 14TeV + PU)

the off-centering of the new BeamSpot is clearly visible:

image

the quality of the IP w.r.t. BeamSpot is similar:

image

but for some reason we are reconstructing substantially less (?) tracks:

image

the same effect is NOT visible in the non-PU wf 11634.0 (TTbar 2021, 14TeV)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bbf307e into cms-sw:master Aug 25, 2022
@mmusich mmusich deleted the Realistic25ns13p6TeVEarly2022Collision branch March 22, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet