Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save EDMNANO in EcalPhiSymRecoSequence #38835

Merged
merged 1 commit into from Jul 23, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Jul 22, 2022

PR description:

Follow-up to dmwm/T0#4664
The EDMNANO files were empty, this PR changes the costumization so it saves the EDMNANO output.

PR validation:

cmsrel CMSSW_12_5_X_2022-07-22-1100
cd CMSSW_12_5_X_2022-07-22-1100/src/
cmsenv
git cms-addpkg Calibration/EcalCalibAlgos
git cms-addpkg Configuration/DataProcessing
xrdcp root://cms-xrd-global.cern.ch//store/backfill/1/data/Tier0_REPLAY_2022/AlCaPhiSym/RAW/v1907/000/346/512/00000/d3a50f06-9dc2-4e39-9c3d-249e8f1f9dfe.root .
mv d3a50f06-9dc2-4e39-9c3d-249e8f1f9dfe.root input.root
python3 Configuration/DataProcessing/test/RunPromptReco.py --lfn=file:input.root --alcareco EcalPhiSymByRun --global-tag 124X_dataRun3_Prompt_v4
cmsRun -e RunPromptRecoCfg.py
root output.root
Runs->Print()

gives the correct EDMNANO content, verified by the experts @simonepigazzini

I also ran runTheMatrix.py -l 139.005

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Need to backport to 12_4_X

@tvami
Copy link
Contributor Author

tvami commented Jul 22, 2022

test parameters:

  • workflows = 139.005

@tvami
Copy link
Contributor Author

tvami commented Jul 22, 2022

type ecal,bugfix

@tvami
Copy link
Contributor Author

tvami commented Jul 22, 2022

@cmsbuild , please test

@tvami
Copy link
Contributor Author

tvami commented Jul 22, 2022

urgent

  • backport is urgent

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38835/31218

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Calibration/EcalCalibAlgos (alca)

@malbouis, @tvami, @yuanchao, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks.
@rchatter, @tocheng, @argiro, @thomreis, @simonepigazzini, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-598197/26404/summary.html
COMMIT: 7376239
CMSSW: CMSSW_12_5_X_2022-07-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38835/26404/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-598197/139.005_AlCaPhiSym2021+AlCaPhiSym2021+RECOALCAECALPHISYMDR3+ALCAECALPHISYM

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3706484
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3706460
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 213 log files, 47 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@ChrisMisan
Copy link
Contributor

ChrisMisan commented Jul 23, 2022

+alca

  • wf 139.005 passes
  • differences only in MTD

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e60941f into cms-sw:master Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants