Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Run2 electron IDs in Run3 nano for early analyses #38853

Merged
merged 1 commit into from Jul 30, 2022

Conversation

swagata87
Copy link
Contributor

PR description:

Run2 electron IDs are currently disabled in run3 nano. This is problematic because some early Run3 analyses need at least some kind of built-in ID in nano, and Run3 specific IDs will need some time to be ready. In this PR, we are enabling Run2 electron IDs in Run3 nano. The same for photon IDs (+necessary fixes to make the full chain work) was done in #38810.

I have also enabled the electron nano DQM, which I found to be disabled in Run3 nano! I don't see why it should be disabled, so I had enabled it.

PR validation:

runTheMatrix.py -l 11634.0 had worked.

I think we would need a backport of this to 12_4_X, because Run3 nano production will be in 12_4_X.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38853/31252

  • This PR adds an extra 24KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@swagata87
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26f85f/26437/summary.html
COMMIT: 2c15efe
CMSSW: CMSSW_12_5_X_2022-07-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38853/26437/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3667670
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3667646
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 124.56000000000002 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 20.760 KiB Physics/NanoAODDQM
  • Checked 210 log files, 47 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mariadalfonso
Copy link
Contributor

mariadalfonso commented Jul 30, 2022

the whole sets of ID is there now for Run3
https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/-/issues/169

Screen Shot 2022-07-30 at 10 00 20

Screen Shot 2022-07-30 at 10 05 20

As note:

  1. mvaHZZIso can be add in the DQM as well in the future but it's there for Run3
    https://cms-nanoaod-integration.web.cern.ch/integration/38853/mc123Xrun3_size_report.html#Electron

  2. the dEscale and dEsigma for systematic variation are not there for Run3 but only for Run2

@mariadalfonso
Copy link
Contributor

+xpog

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 166c583 into cms-sw:master Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants