New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep Run2 electron IDs in Run3 nano for early analyses #38853
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38853/31252
|
A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master. It involves the following packages:
@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26f85f/26437/summary.html Comparison SummarySummary:
|
the whole sets of ID is there now for Run3 As note:
|
+xpog |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Run2 electron IDs are currently disabled in run3 nano. This is problematic because some early Run3 analyses need at least some kind of built-in ID in nano, and Run3 specific IDs will need some time to be ready. In this PR, we are enabling Run2 electron IDs in Run3 nano. The same for photon IDs (+necessary fixes to make the full chain work) was done in #38810.
I have also enabled the electron nano DQM, which I found to be disabled in Run3 nano! I don't see why it should be disabled, so I had enabled it.
PR validation:
runTheMatrix.py -l 11634.0
had worked.I think we would need a backport of this to 12_4_X, because Run3 nano production will be in 12_4_X.