[124X backport] HCAL: Group 0 LUT edited to set LLP bits in HB only, not HE

[gk199]

PR description:

Edits are made such that the HCAL Group 0 LUT only sets LLP bits in HB, not HE. Current uHTR firmware only accepts the LUTs with the high bits (bits 12-15) set in HB, not in HE. This can be reversed to set the LUT bits for both HB and HE when the firmware is modified. The initial PR setting the HCAL LUT is in PR #35599, where more details on the specifications are given as well. Discussed with @Michael-Krohn in detail about the HCAL LUT generation.

PR validation:

Prepared in CMSSW_12_4_X_2022-07-31-2300.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of PR #38896 as these PRs are created to match what is done currently on detector in the HCAL uHTRs, so it is considered a bug fix. Backport to 12_4_X as this is relevant for Run 3 physics data taking.

[cmsbuild]

A new Pull Request was created by @gk199 (Gillian Kopp) for CMSSW_12_4_X.

It involves the following packages:

• CalibCalorimetry/HcalTPGAlgos (l1, alca)

@malbouis, @yuanchao, @epalencia, @cmsbuild, @rekovic, @saumyaphor4252, @tvami, @ChrisMisan, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@bsunanda, @mmusich, @abdoulline, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from HCAL: Group 0 LUT edited to set LLP bits in HB only, not HE #38896

[tvami]

backport of #38896

[tvami]

type hcal,bugfix

[tvami]

@cmsbuild , please test

[tvami]

@gk199 please include in the title that it's for 12_4_X like "[124X backport] HCAL: Group 0 LUT edited to set LLP bits in HB only, not HE"

[aandvalenzuela]

Test relvals input was stuck and I needed to restart it. It is running fine now and it seems results will be reported soon :)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdcffd/26574/summary.html
COMMIT: b4b7d1b
CMSSW: CMSSW_12_4_X_2022-08-01-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38923/26574/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3676198
• DQMHistoTests: Total failures: 51
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3676124
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: found differences in 1 / 49 workflows

[ChrisMisan]

+alca

• differences in the comparison were expected
• tests pass
• main pr approved

[epalencia]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[tvami]

urgent

• for the release today

[qliphy]

+1