Adds FED ID 1405 for uGT Testcrate for L1T Ntuples

[dpilipov]

PR description:

New code and edits to existing code allow for access to the uGT Testcrate, FedId = 1405:

• changes to output: no changes to ouput,
• dependencies: there are no additional PR or external dependencies,
• additional useful material: see Indico L1 Menu Working meeting https://indico.cern.ch/event/1191249/

PR validation:

This PR has been validated by

1. verifying that it compiles correctly,
   

2. verifying that the results were checked with L1TNtuple and were as expected,
   

3. verifying that the runTheMatrix test runs successfully,
   

4. verifying that it passes the scram build code-format.
   

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39104/31641

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File EventFilter/L1TRawToDigi/python/gtTestcrateStage2Digis_cfi.py modified in PR(s): WIP: Unpack uGT testcrate data #37481
  • File L1Trigger/Configuration/python/L1TRawToDigi_cff.py modified in PR(s): WIP: Unpack uGT testcrate data #37481
  • File L1Trigger/L1TNtuples/python/L1NtupleRAW_cff.py modified in PR(s): WIP: Unpack uGT testcrate data #37481
  • File L1Trigger/L1TNtuples/python/l1uGTTestcrateTree_cfi.py modified in PR(s): WIP: Unpack uGT testcrate data #37481

[cmsbuild]

A new Pull Request was created by @dpilipov for master.

It involves the following packages:

• EventFilter/L1TRawToDigi (l1)
• L1Trigger/Configuration (l1)
• L1Trigger/L1TNtuples (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@kreczko, @eyigitba, @Martin-Grunewald, @missirol, @thomreis, @dinyar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[elfontan]

(Tagging @dinyar who originally worked on this implementation in case he has chance to have a look, too.)
Thanks @dpilipov for preparing this PR!
Would it be maybe worth to add at least a comment in implementations_stage2/GTSetup.cc to keep track in a clear way of the FED number meaning?

[dinyar]

Hi Elisa,

Thanks for the heads-up! I skimmed across the changes and I think this is a superset of what I had in #37481, so from my side this looks good!

Cheers,
Dinyar

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb9c86/26923/summary.html
COMMIT: 855bda3
CMSSW: CMSSW_12_5_X_2022-08-18-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39104/26923/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3693040
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3693010
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[dpilipov]

Added a comment regarding the addition of the test crate FedId 1405 in packing and unpacking.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39104/31777

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File EventFilter/L1TRawToDigi/python/gtTestcrateStage2Digis_cfi.py modified in PR(s): WIP: Unpack uGT testcrate data #37481
  • File L1Trigger/Configuration/python/L1TRawToDigi_cff.py modified in PR(s): WIP: Unpack uGT testcrate data #37481
  • File L1Trigger/L1TNtuples/python/L1NtupleRAW_cff.py modified in PR(s): WIP: Unpack uGT testcrate data #37481
  • File L1Trigger/L1TNtuples/python/l1uGTTestcrateTree_cfi.py modified in PR(s): WIP: Unpack uGT testcrate data #37481

[cmsbuild]

Pull request #39104 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb9c86/27150/summary.html
COMMIT: 1cd75b5
CMSSW: CMSSW_12_5_X_2022-08-28-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39104/27150/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3695708
• DQMHistoTests: Total failures: 23
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695663
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[dpilipov]

Hi Elisa, Sure. I will also prepare a short general recipe for full implementation/access of Testcrate should that ever be desired down the road (including HLT). Best Regards, Dragana

…

Sent from my iPhone

On Aug 19, 2022, at 2:53 AM, Elisa Fontanesi ***@***.***> wrote:  (Tagging @dinyar who originally worked on this implementation in case he has chance to have a look, too.) Thanks @dpilipov for preparing this PR! Would it be maybe worth to add at least a comment in implementations_stage2/GTSetup.cc to keep track in a clear way of the FED number meaning? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.