Run3-alca228X Backport to 12_4_X the PR #39116 which modifies IsolatedBunchSelector and HcalNoise AlCaReco

[bsunanda]

PR description:

Backport PR #39116 which modifies IsolatedBunchSelector and HcalNoise AlCaReco

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_12_4_X.

It involves the following packages:

• Calibration/HcalAlCaRecoProducers (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Run3-alca228 Update for isolated bunch selector AlCaReco #39116

[tvami]

hold

• the review in master should finish first...

[cmsbuild]

Pull request has been put on hold by @tvami
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[ChrisMisan]

backport of #39116

[tvami]

also @bsunanda please include in the title that this is to 12_4_X (backport could be to 10_6_X too..)

[bsunanda]

@cmsbuild Please test

[tvami]

@cmsbuild , please abort

[tvami]

@bsunanda what about propagating the changes from the master PR to this one?

[cmsbuild]

Pull request #39117 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

[cmsbuild]

Pull request #39117 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7879e/26944/summary.html
COMMIT: 06d3120
CMSSW: CMSSW_12_4_X_2022-08-19-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39117/26944/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3677242
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 2
• DQMHistoTests: Total successes: 3677208
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.012 KiB( 49 files compared)
• DQMHistoSizes: changed ( 1000.0 ): -0.004 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 1000.0,... ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: found differences in 1 / 49 workflows

[bsunanda]

@tvami The PR to master is approved and added. Please uphold and approve this PR. This PR matches withe the PR merged to the master

[tvami]

unhold

[tvami]

+alca

• tests pass, IB test are running good

[tvami]

urgent

• we'd like this in the next release

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Verbatim backport of Run3-alca228 Update for isolated bunch selector AlCaReco #39116