Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update input of phase2_digi_reco_pixelntuple unit test #39123

Merged

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Aug 20, 2022

PR description:

This PR update the input of SLHCUpgradeSimulations/Geometry/test/phase2_digi_reco_pixelntuple_cfg.py from SingleMu GEN-SIM-RECO to GEN-SIM. This PR will avoid the unit failure when L1T PR (#38442) is merged due to removed collection.

I use this chance also to remove obsolete L1Reco step from Phase2 sequence.

The PR test is trigger with #38442 to show that there will be no unit test failure anymore. However, this PR can be merged first (independent of #38442).

PR validation:

Run locally,
cmsRun phase2_digi_reco_pixelntuple_cfg.py

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, and no need of backport

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39123/31678

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • SLHCUpgradeSimulations/Geometry (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@trtomei, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

@cmsbuild please test with #38442,cms-data/L1Trigger-Phase2L1ParticleFlow#4

Copy link
Contributor

@mmusich mmusich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@@ -19,7 +19,7 @@
process.load('Configuration.StandardSequences.DigiToRaw_cff')
process.load('HLTrigger.Configuration.HLT_Fake2_cff')
process.load('Configuration.StandardSequences.RawToDigi_cff')
process.load('Configuration.StandardSequences.L1Reco_cff')
#process.load('Configuration.StandardSequences.L1Reco_cff')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed for good, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. We already remove it from the main Phase-2 sequence.

Here is the issue we discussed,
#33012

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so instead of commenting can you delete the line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39123/31679

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #39123 was updated. @civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

@srimanob
Copy link
Contributor Author

test parameters:

@srimanob
Copy link
Contributor Author

srimanob commented Aug 23, 2022

FYI @perrotta @qliphy
This PR will be needed, to avoid the unit test failure after merging L1T PR (#38442)

FYI @missirol @mmusich
I update to SingleMu GEN-SIM as the script is expected to run on SingleMu input, and no need the follow up PR.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39123/31732

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #39123 was updated. @civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@missirol
Copy link
Contributor

Looks good @srimanob (unit test passed); you might want to update the title of the PR.

@srimanob srimanob changed the title Temporary disable L1TrackTrigger in PixelNtuple unit test Update input of phase2_digi_reco_pixelntuple unit test Aug 24, 2022
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9264b/27021/summary.html
COMMIT: 4b0fa02
CMSSW: CMSSW_12_5_X_2022-08-23-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39123/27021/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9264b/27021/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9264b/27021/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 16635 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3693084
  • DQMHistoTests: Total failures: 218221
  • DQMHistoTests: Total nulls: 11
  • DQMHistoTests: Total successes: 3474830
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 907.1800000000001 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 113.398 KiB L1T/L1TPhase2
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 1 / 50 workflows

@srimanob
Copy link
Contributor Author

+Upgrade

This is technical PR, to avoid unit test failure when L1 collection is dropped. The failure in comparison does not come from this PR.

@srimanob
Copy link
Contributor Author

srimanob commented Aug 24, 2022

@civanch could you please re-sign. Thanks.

@bsunanda
Copy link
Contributor

+geometry

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants