[12.4.X] Fix for SiPixelLorentzAnglePCLHarvester after #39075

[mmusich]

backport of #39122

PR description:

When scrutinizing the output of the CMSSW_12_4_7 replay in the offline test GUI it was noticed that PR #39075 introduced a couple of issues:

• the name of the fit function at

  cmssw/CalibTracker/SiPixelLorentzAngle/src/SiPixelLorentzAnglePCLHarvester.cc

  Line 635 in ff37043

  f1_ = std::make_unique<TF1>("fPolynomial",

• was changed going out-of-synch with the one of the render plugin defined at SiPixelLorentzAnglePCLRenderPlugin.cc#L199 and causing the not correct rendering of the fits in the GUI, cf https://tinyurl.com/2qkryzg2;
• the cut on the covariance matrix status introduced at

  cmssw/CalibTracker/SiPixelLorentzAngle/src/SiPixelLorentzAnglePCLHarvester.cc

  Line 766 in ff37043

  const bool covMatrixStatusCut = (res.covMatrixStatus == SiPixelLAHarvest::kAccurate);

  results too strict for the measurements to pass it, resulting in none of them to be accepted (cf. https://tinyurl.com/2ekl8s7c ).

This PR fixes both issues, by:

• restoring the name of the fit function to be synchronized with the render plugin (an assertion statement is also introduced such that it is not changed again by mistake later);
• the cut on the covariance matrix status is loosened to accept also kMadePosDef grade fits;

Finally I profit of this PR to improve the diagnostics, by including a dashboard histogram to show what quality cuts fails.

PR validation:

Manually re-run the configuration for the multi-run harvesting (MRH ID 325019) from:
/eos/cms/store/group/alca_global/multiruns/results/prod//el8_amd64_gcc10/CMSSW_12_4_6/325019/

and obtained the following file, displayed in a private GUI reachable via:

 ssh -NL 8060:localhost:8060 <USER>@lxplus724.cern.ch

and visiting https://tinyurl.com/2mo3on59.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #39122 to CMSSW_12_4_X for data-taking operations

[mmusich]

type trk, bug-fix

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

• CalibTracker/SiPixelLorentzAngle (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@tocheng, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix for SiPixelLorentzAnglePCLHarvester after #38996  #39122

[mmusich]

test parameters:

• workflow = 1001.2

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51c9c3/26961/summary.html
COMMIT: 216a222
CMSSW: CMSSW_12_4_X_2022-08-21-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39129/26961/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-51c9c3/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA+ALCAHARVD4+ALCAHARVDSIPIXELALIHG

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3677303
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3677261
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 215 log files, 45 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1