Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old scripts accessing geometry with prior-run2 GT in Calibration/TkAlCaRecoProducers #39150

Closed
wants to merge 1 commit into from

Conversation

yuanchao
Copy link
Contributor

PR description:

Following the up the migration of Geometry_cff to GeometryDB_cff (#35278), proper GlobalTag needs to be set in advance. We take the chance to clean up deprecated AlCa/DB script in TkAlCaRecoProducers.

PR validation:

Remove deprecated scripts: Alca_BeamFit_Workflow.py, Alca_BeamSpot_Harvester.py (GR_R_38X_V9)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a back port and no back port expected.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39150/31727

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @yuanchao (Yuan CHAO) for master.

It involves the following packages:

  • Calibration/TkAlCaRecoProducers (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @threus, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Aug 23, 2022

assign tracking-pog

@cmsbuild
Copy link
Contributor

New categories assigned: tracking-pog

@slava77,@mmusich,@vmariani you have been requested to review this Pull request/Issue and eventually sign? Thanks

@mmusich
Copy link
Contributor

mmusich commented Aug 24, 2022

@ChrisMisan
Copy link
Contributor

-alca

  • to remove this PR from pending queue

@tvami
Copy link
Contributor

tvami commented Aug 24, 2022

@yuanchao given the PR #39170 please close this one, thanks

@yuanchao
Copy link
Contributor Author

Close for #39170 is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants