Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Fix try/catch in Vx3DHLTAnalyzer #39341

Conversation

francescobrivio
Copy link
Contributor

PR description:

Backport of #39285
Fix the try/catch statement added in the DQM client Vx3DHLTAnalyzer to protect the client against Minuit2 FatalRootError.

PR validation:

The crash observed online is solved when applying this PR.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #39285

FYI @dinardo

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2022

A new Pull Request was created by @francescobrivio for CMSSW_12_4_X.

It involves the following packages:

  • DQM/BeamMonitor (dqm, db)

@malbouis, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @saumyaphor4252, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

backport of #39285

@francescobrivio
Copy link
Contributor Author

type bug-fix

@francescobrivio
Copy link
Contributor Author

test parameters:

  • addpkg = DQM/Integration

@francescobrivio
Copy link
Contributor Author

urgent

  • to be included in the next 12_4_X release for data-taking

@cmsbuild cmsbuild added the urgent label Sep 7, 2022
@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@emanueleusai
Copy link
Member

testing at P5

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-215ed4/27413/summary.html
COMMIT: 684d48f
CMSSW: CMSSW_12_4_X_2022-09-07-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39341/27413/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677280
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3677256
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@syuvivida
Copy link
Contributor

@francescobrivio we tested this PR 39341 at playback using run 357900 (the run that crashed before) and the run finished ok without crash from the beampixel client.

@francescobrivio
Copy link
Contributor Author

+db

@syuvivida
Copy link
Contributor

+1

1 similar comment
@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@rappoccio rappoccio merged commit d2b689a into cms-sw:CMSSW_12_4_X Sep 9, 2022
@francescobrivio francescobrivio deleted the alca-fix_Vx3DHLTAnalyzer_12_4_X branch September 14, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants