New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12_4_X] Fix try/catch in Vx3DHLTAnalyzer #39341
[12_4_X] Fix try/catch in Vx3DHLTAnalyzer #39341
Conversation
A new Pull Request was created by @francescobrivio for CMSSW_12_4_X. It involves the following packages:
@malbouis, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @saumyaphor4252, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
backport of #39285 |
type bug-fix |
test parameters:
|
urgent
|
@cmsbuild please test |
testing at P5 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-215ed4/27413/summary.html Comparison SummarySummary:
|
@francescobrivio we tested this PR 39341 at playback using run 357900 (the run that crashed before) and the run finished ok without crash from the beampixel client. |
+db |
+1 |
1 similar comment
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Backport of #39285
Fix the
try/catch
statement added in the DQM clientVx3DHLTAnalyzer
to protect the client against Minuit2 FatalRootError.PR validation:
The crash observed online is solved when applying this PR.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #39285
FYI @dinardo