Bugfix to the destructor of two TkDQM scripts

[tvami]

PR description:

Tracker Offline DQM shift scripts, such as
python3 PhaseITreeProducer.py DQM_V0001_R000359278__ZeroBias__Run2022E-PromptReco-v1__DQMIO.root
gave the following

Histograms to read 114
Histograms saved to internal data structure
Data saved as TTree object
Exception ignored in: <function ModuleLvlValuesReader.__del__ at 0x7f99aa46ed30>
Traceback (most recent call last):
  File "/data/vami/projects/DQM/CMSSW_12_4_9/src/DQM/SiStripMonitorClient/scripts/PhaseITreeProducer.py", line 317, in __del__
AttributeError: 'CPyCppyy_NoneType' object has no attribute 'IsOpen'

After adding a check on the existence, this is gone.

PR validation:

PhaseITreeProducer.py runs fine.
Added new unit test

scram b runtests_test_TreeAndTkMapProducer

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

PhaseITreeProducer.py is used during the shifts for every run, so it should be backported to 12_4_X (and then of course 12_5_X too)

[tvami]

type bugfix,trk

[tvami]

@cmsbuild , please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39573/32358

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/SiStripMonitorClient/scripts/PhaseITreeProducer.py modified in PR(s): Modernize SiStripMonitorClient #39518
  • File DQM/SiStripMonitorClient/scripts/TH2PolyOfflineMaps.py modified in PR(s): Modernize SiStripMonitorClient #39518

[cmsbuild]

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

• DQM/SiStripMonitorClient (dqm)

@emanueleusai, @ahmad3213, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @mmusich, @threus, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f5e4b0/27916/summary.html
COMMIT: 6be16b8
CMSSW: CMSSW_12_6_X_2022-10-02-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39573/27916/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f5e4b0/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3432650
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3432625
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 49 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mmusich]

wondering if these two files could be included in a unit test by supplying the needed input file using the same mechanism that is used for the Tracker Maps testing:

cmssw/DQM/SiStripMonitorClient/test/test_SiStripDQM_OfflineTkMap.sh

Line 5 in 6be16b8

DQMFILE="/store/group/comm_dqm/DQMGUI_data/Run2018/ZeroBias/R0003191xx/DQM_V0001_R000319176__ZeroBias__Run2018B-PromptReco-v2__DQMIO.root"

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39573/32387

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/SiStripMonitorClient/scripts/PhaseITreeProducer.py modified in PR(s): Modernize SiStripMonitorClient #39518
  • File DQM/SiStripMonitorClient/scripts/TH2PolyOfflineMaps.py modified in PR(s): Modernize SiStripMonitorClient #39518

[tvami]

urgent

• backport would be nice to be part of the next 12_4_X

[tvami]

@cmsbuild , please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39573/32406

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/SiStripMonitorClient/scripts/PhaseITreeProducer.py modified in PR(s): Modernize SiStripMonitorClient #39518
  • File DQM/SiStripMonitorClient/scripts/TH2PolyOfflineMaps.py modified in PR(s): Modernize SiStripMonitorClient #39518

[cmsbuild]

Pull request #39573 was updated. @emanueleusai, @ahmad3213, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f5e4b0/27992/summary.html
COMMIT: bc2c043
CMSSW: CMSSW_12_6_X_2022-10-04-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39573/27992/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f5e4b0/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3432650
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3432625
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 49 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1