Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MUO] Suppress excessive warnings in muon tracking at HLT #39596

Merged
merged 1 commit into from Oct 9, 2022

Conversation

khaosmos93
Copy link
Contributor

PR description:

Follow-up PR for issue #39234

Demoting the warning message for an empty trajectory in RecoMuon/GlobalTrackingTools/src/GlobalTrajectoryBuilderBase.cc from LogWarning to LogDebug.
The warning mostly occurs when there are insufficient hits (< 7) to rebuild the trajectory.
No impact on muon tracking performance is expected.

PR validation:

Tested in CMSSW_12_6_X_2022-10-03-1100 using the following menu

hltGetConfiguration /dev/CMSSW_12_4_0/GRun \
--eras Run3 \
--globaltag 124X_dataRun3_HLT_forTSG_newJECs_v1 \
--data \
--unprescale \
--output none \
--max-events 1000 \
--l1-emulator uGT --l1 L1Menu_Collisions2022_v1_3_0-d1_xml \
--input root://eoscms.cern.ch//eos/cms/store/data/Run2022C/Muon/RAW/v1/000/356/578/00000/fbf0187b-2564-4dd1-bee8-eccb0a4c8086.root

Before update:

Severity    # Occurrences   Total Occurrences
--------    -------------   -----------------
Info               150096              150096
FwkInfo            195203              195203
Warning               617                 617
Error                  41                  41
System                  3                   3

After update:

Severity    # Occurrences   Total Occurrences
--------    -------------   -----------------
Info               150096              150096
FwkInfo            195203              195203
Warning                 5                   5
Error                  41                  41
System                  3                   3

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39596/32392

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2022

A new Pull Request was created by @khaosmos93 (Minseok Oh) for master.

It involves the following packages:

  • RecoMuon/GlobalTrackingTools (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@bellan, @andrea21z, @abbiendi, @JanFSchulte, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @CeliaFernandez, @trocino, @amagitte, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor

missirol commented Oct 5, 2022

please test

The 12_4_X backport of this PR is relevant to HLT online operations.

I kindly ask @cms-sw/reconstruction-l2 to review it with some priority.

@perrotta
Copy link
Contributor

perrotta commented Oct 6, 2022

please abort
(trying to recover resources for the tests of more urgent PRs)

@aandvalenzuela
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2022

-1

Failed Tests: AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7817d2/28070/summary.html
COMMIT: adf215d
CMSSW: CMSSW_12_6_X_2022-10-05-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39596/28070/install.sh to create a dev area with all the needed externals and cmssw changes.

AddOn Tests

----- Begin Fatal Exception 06-Oct-2022 17:08:49 CEST-----------------------
An exception of category 'NotFound' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
Exception Message:
Service no ServiceRegistry has been set for this thread 
----- End Fatal Exception -------------------------------------------------

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /pool/condor/dir_32386/jenkins/workspace/compare-root-files-short-matrix/data/PR-7817d2/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3391103
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3391078
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

missirol commented Oct 7, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7817d2/28103/summary.html
COMMIT: adf215d
CMSSW: CMSSW_12_6_X_2022-10-06-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39596/28103/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7817d2/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3391103
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3391069
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Oct 9, 2022

+1

@cmsbuild cmsbuild merged commit 668c12b into cms-sw:master Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants