Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] RPCDqmClient crash fix for 0 LS runs #39630

Merged
merged 1 commit into from Oct 12, 2022

Conversation

pmandrik
Copy link
Contributor

@pmandrik pmandrik commented Oct 5, 2022

PR description:

To fix another RPC client crash place in online DQM when 0 LS are in the run ([0]).

[0] https://cmsweb.cern.ch/dqm/dqm-square-k8/api?what=get_logs&id=dqm-source-state-run359813-hostfu-c2f11-11-03-pid038886&db=production

PR validation:

Tested locally, to be tested at P5

@pmandrik
Copy link
Contributor Author

pmandrik commented Oct 5, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2022

A new Pull Request was created by @pmandrik (Petr Mandrik) for CMSSW_12_4_X.

It involves the following packages:

  • DQM/RPCMonitorClient (dqm)

@emanueleusai, @ahmad3213, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@acimmino this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@rappoccio
Copy link
Contributor

Backport of #39633. Must be added in 12_6 first.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acc514/28026/summary.html
COMMIT: 8da01ad
CMSSW: CMSSW_12_4_X_2022-10-05-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39630/28026/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677402
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3677372
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

waiting for tests at p5 to complete

cmsbuild added a commit that referenced this pull request Oct 11, 2022
[12_5_X] RPCDqmClient crash fix for 0 LS runs #39630
@syuvivida
Copy link
Contributor

waiting for tests at p5 to complete

test at p5 was successful

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cdcffbe into cms-sw:CMSSW_12_4_X Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants