New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLT release validation and offline DQM for EXO Run 3 HLT paths (12_4_X) #39800
HLT release validation and offline DQM for EXO Run 3 HLT paths (12_4_X) #39800
Conversation
… since photon histograms weren't filled
…tersNoVtx_v and HLT_TrkMu17_DoubleTrkMu8NoFiltersNoVtx_v; make it not required to have all paths valid in the numerator and denominator
A new Pull Request was created by @jalimena (Juliette Alimena) for CMSSW_12_4_X. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-645837/28412/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@jalimena since you are backporting to 12_4, please also provide the backport for the intermediate cycle 12_5_X |
backport of #39799 |
@jalimena just to confirm, there are a lot more files changed here than in the 12_6 version, is that expected? |
@rappoccio , Yes, because, as I said, it is a backport of both #38848 and #39799 |
+1
|
PR description:
This PR is a backport of #38848 (which I didn't realize I needed at the time) and #39799
#38848:
This PR updates the exotica HLT release validation (in HLTriggerOffline/Exotica) and the HLT offline DQM (in DQMOffline/Trigger) to include the new long-lived particle (LLP) paths that went into V1.2 and 1.3 of the Run 3 HLT menu [1]. Complying with the request from STEAM to limit the number of histograms produced, only signal paths are monitored, and not backup or control paths. So, these paths have been added to the monitoring:
and these paths have been removed (since they have been superseded by some paths above):
As a result, some histograms will be added, and a few will be removed.
#39799:
This PR:
HLT_TrkMu16_DoubleTrkMu6NoFiltersNoVtx_v
andHLT_TrkMu17_DoubleTrkMu8NoFiltersNoVtx_v
MuonMonitor_cff
The reason for the second part is because in the HLT 2022 v1.3 menu, one of the paths in the denominator was removed. As a result, the DQM plots did not get made, although they would have been fine, physics-wise. Changing this flag to false is the easiest way to have similar DQM plots with the earlier and later HLT menus, and it fixes this bug.
As a result of this PR, some DQM plots will be removed, and some will reappear.
PR validation:
Using the 11634.0 ttbar workflow, I have tested that the correct histograms are produced and filled in the harvested DQM file.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #38848 and #39799 . This backport is needed so that the plots show up in the offline DQM GUI, which uses 12_4_X.