Run iii electron cut based #39839

rgoldouz · 2022-10-25T09:44:50Z

PR description:

Dear Experts,

Based on the the following request for adding Run3 electron cut based IDs,
#39759

I have added the run3 IDs to the nanoAOD. We would like to keep the Run2 IDs. Therefore, I have added a new branch for Run3 ID that is called "cutBasedRunIIIWinter22". So we have two branches for the electron cut based IDs, "cutBased" branch which is for Run2 IDs and "cutBasedRunIIIWinter22" which for run3 IDs. I have also added the corresponding bitmap branch.

Please let me know your comments.

Thanks,
Reza

@swagata87 @a-kapoor @DebabrataBhowmik

… EGamma IDs

…topic

cmsbuild · 2022-10-25T09:52:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39839/32720

This PR adds an extra 32KB to repository
Found files with invalid states:
- RecoEgamma/ElectronIdentification/python/Identification/cutBasedElectronID_Fall22_122X_V1_cff.py:
  - Added: 64c6a69
  - Modified: 7fdaba7
  - Deleted: 16dc582
- RecoEgamma/ElectronIdentification/data/Run3_Fall22/effAreaElectrons_cone03_pfNeuHadronsAndPhotons_122X.txt:
  - Added: 64c6a69
  - Deleted: 16dc582
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): NANO configuration Cleanup #39796
- File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Adding MVA ID to nanoAOD code #39355
- File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): Electron cut-based ID for Run3 from EGamma PR #39759
- File RecoEgamma/ElectronIdentification/data/Run3_Winter22/effAreaElectrons_cone03_pfNeuHadronsAndPhotons_122X.txt modified in PR(s): Electron cut-based ID for Run3 from EGamma PR #39759
- File RecoEgamma/ElectronIdentification/python/Identification/cutBasedElectronID_Winter22_122X_V1_cff.py modified in PR(s): Electron cut-based ID for Run3 from EGamma PR #39759
- File RecoEgamma/ElectronIdentification/test/runtests.sh modified in PR(s): Electron cut-based ID for Run3 from EGamma PR #39759

cmsbuild · 2022-10-25T09:53:22Z

A new Pull Request was created by @rgoldouz (Reza Goldouzian) for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)
PhysicsTools/PatAlgos (xpog, reconstruction)
RecoEgamma/ElectronIdentification (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jainshilpi, @schoef, @emilbols, @mbluj, @demuller, @varuns23, @seemasharmafnal, @mmarionncern, @jdolen, @ahinzmann, @lgray, @missirol, @Prasant1993, @azotz, @Sam-Harper, @jdamgov, @nhanvtran, @gkasieczka, @hatakeyamak, @andrzejnovak, @AlexDeMoor, @AnnikaStein, @valsdav, @JyothsnaKomaragiri, @sobhatta, @afiqaize, @gpetruc, @wrtabb, @mariadalfonso, @sameasy, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

swagata87 · 2022-10-25T10:18:53Z

so this PR already contain #39759, then I guess that one can be closed and this one can be reviewed? is that fine?

swertz · 2022-10-25T11:28:49Z

so this PR already contain #39759, then I guess that one can be closed and this one can be reviewed? is that fine?

Yes, please do.

rgoldouz · 2022-10-25T12:26:23Z

Hello Experts,

I just made a new commit where I have modified the address of the effective area file to use the one for Run3.

I think my latest commit
"@rgoldouz
RunIII electron ID is added + new effArea"

Will be merged. Right?

Thanks,
Reza

@swagata87 @a-kapoor @DebabrataBhowmik

cmsbuild · 2022-10-25T12:30:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39839/32722

This PR adds an extra 32KB to repository
Found files with invalid states:
- RecoEgamma/ElectronIdentification/python/Identification/cutBasedElectronID_Fall22_122X_V1_cff.py:
  - Added: 64c6a69
  - Modified: 7fdaba7
  - Deleted: 16dc582
- RecoEgamma/ElectronIdentification/data/Run3_Fall22/effAreaElectrons_cone03_pfNeuHadronsAndPhotons_122X.txt:
  - Added: 64c6a69
  - Deleted: 16dc582
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): NANO configuration Cleanup #39796
- File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Adding MVA ID to nanoAOD code #39355
- File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): Electron cut-based ID for Run3 from EGamma PR #39759
- File RecoEgamma/ElectronIdentification/data/Run3_Winter22/effAreaElectrons_cone03_pfNeuHadronsAndPhotons_122X.txt modified in PR(s): Electron cut-based ID for Run3 from EGamma PR #39759
- File RecoEgamma/ElectronIdentification/python/Identification/cutBasedElectronID_Winter22_122X_V1_cff.py modified in PR(s): Electron cut-based ID for Run3 from EGamma PR #39759
- File RecoEgamma/ElectronIdentification/test/runtests.sh modified in PR(s): Electron cut-based ID for Run3 from EGamma PR #39759

cmsbuild · 2022-10-25T12:30:41Z

Pull request #39839 was updated. @cmsbuild, @mandrenguyen, @clacaputo, @swertz, @vlimant can you please check and sign again.

swertz · 2022-10-27T14:27:50Z

PhysicsTools/NanoAOD/python/electrons_cff.py

@@ -132,8 +144,8 @@ def _get_bitmapVIDForEle_docstring(modules,WorkingPoints):
    relative = cms.bool(False),
    rho_MiniIso = cms.InputTag("fixedGridRhoFastjetAll"),
    rho_PFIso = cms.InputTag("fixedGridRhoFastjetAll"),
-    EAFile_MiniIso = cms.FileInPath("RecoEgamma/ElectronIdentification/data/Fall17/effAreaElectrons_cone03_pfNeuHadronsAndPhotons_94X.txt"),
-    EAFile_PFIso = cms.FileInPath("RecoEgamma/ElectronIdentification/data/Fall17/effAreaElectrons_cone03_pfNeuHadronsAndPhotons_94X.txt"),
+    EAFile_MiniIso = cms.FileInPath("RecoEgamma/ElectronIdentification/data/Run3_Winter22/effAreaElectrons_cone03_pfNeuHadronsAndPhotons_122X.txt"),


Don't we want to keep the Fall17 constants for Run2 samples?

yes, @rgoldouz can you fix it please? It's better to not delete anything related to Run2 IDs, but just add things related to Run3 IDs.

swagata87 · 2022-10-28T15:20:06Z

type egamma

rgoldouz · 2022-11-01T12:50:13Z

Hello @swertz ,

Keeping fall17 files needs more careful considerations.
These effective area files are used in the recalculation of the isolation variables. In my PR, isolation variables are the same as the one used in the run3 ID. If we want to keep isolation variables connected to run2 ID we need to add the same iso variables for run2 ID. Is it feasible by the XPOG people considering the fact that the iso variables are float?

I am also applying another change. We would like to make run3 ID as the default cut based for run3. We also want not to add run3 ID when the code is running on Run2 datasets.
For doing that I am going to use the process modifier. While looking to the code I found many eras that will never be use (I think). Do we have any plan to rerun the nanoAOD code in CMSSW12 on the samples with eras run2_miniAOD_80XLegacy,run2_nanoAOD_94X2016,run2_nanoAOD_94XMiniAODv1,run2_nanoAOD_94XMiniAODv2,run2_nanoAOD_102Xv1 for example.

These era modifications have made the code dirty and difficult to modify/debug. Do you have any plan to clean the code? I can also help if needed.

Please let us know your opinion,
Thanks

swertz · 2022-11-02T17:51:19Z

enable nano

clacaputo · 2022-11-03T11:18:47Z

please test

mandrenguyen · 2022-11-07T07:10:38Z

please abort

mandrenguyen · 2022-11-07T07:11:24Z

please test
(seems tests got stuck)

cmsbuild · 2022-11-07T11:26:01Z

-1

Failed Tests: RelVals-INPUT RelVals-NANO
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d5d06/28810/summary.html
COMMIT: b6beb5b
CMSSW: CMSSW_12_6_X_2022-11-06-2300/el8_amd64_gcc10
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39839/28810/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

2500.02500.0_mc80X+TTbarMINIAOD8.0+NANO_mc8.0+HRV_NANO_mc/step2_mc80X+TTbarMINIAOD8.0+NANO_mc8.0+HRV_NANO_mc.log
2500.12500.1_mc94X2016+TTbar2016MINIAOD9.4v2+NANO_2016mc9.4v2+HRV_NANO_mc/step2_mc94X2016+TTbar2016MINIAOD9.4v2+NANO_2016mc9.4v2+HRV_NANO_mc.log
2500.0012500.001_data80X+MuonEG2016HMINIAOD8.0+NANO_data8.0+HRV_NANO_data/step2_data80X+MuonEG2016HMINIAOD8.0+NANO_data8.0+HRV_NANO_data.log

Expand to see more relval errors ...

2500.11

RelVals-NANO

2500.02500.0_mc80X+TTbarMINIAOD8.0+NANO_mc8.0+HRV_NANO_mc/step2_mc80X+TTbarMINIAOD8.0+NANO_mc8.0+HRV_NANO_mc.log
2500.12500.1_mc94X2016+TTbar2016MINIAOD9.4v2+NANO_2016mc9.4v2+HRV_NANO_mc/step2_mc94X2016+TTbar2016MINIAOD9.4v2+NANO_2016mc9.4v2+HRV_NANO_mc.log
2500.0012500.001_data80X+MuonEG2016HMINIAOD8.0+NANO_data8.0+HRV_NANO_data/step2_data80X+MuonEG2016HMINIAOD8.0+NANO_data8.0+HRV_NANO_data.log

Expand to see more relval errors ...

2500.11

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 9971 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3416402
DQMHistoTests: Total failures: 23054
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3393326
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 2.326 KiB( 47 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 0.240 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 11834.0 ): 0.415 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13234.0,... ): 0.157 KiB Physics/NanoAODDQM
Checked 206 log files, 48 edm output root files, 48 DQM output files
TriggerResults: found differences in 3 / 46 workflows

swertz · 2022-11-07T15:38:31Z

@rgoldouz tests on 80X and 94X samples fail because the new ID is not added here:

cmssw/PhysicsTools/NanoAOD/python/electrons_cff.py

Line 61 in b6beb5b

for modifier in run2_miniAOD_80XLegacy,run2_nanoAOD_94X2016:

However, support for these old inputs is being dropped in #39796, so once that is merged you will be able to rebase your PR without having to worry about 80X and 94X.

In the meanwhile you could take care of the pending item about isolation/EA?

EDIT: #39796 has been merged, so you'll need to rebase...

DebabrataBhowmik and others added 8 commits October 16, 2022 10:58

Adding Run3 electron cut-based ID

64c6a69

Adding Run3 electron cut-based ID and modifying for miniAOD

fbabfb3

Run3 electron cut-based ID modification and correcting for miniAOD

7fdaba7

Adding Run3 elctron cut-based ID with corrected version name

16dc582

Adding Run3 electron cut-based ID with identical version name for all…

2683101

… EGamma IDs

Run3 electron cut-based ID with EGamma approved information

2e810de

Merged electronID_PR from repository DebabrataBhowmik with cms-merge-…

b504a2d

…topic

RunIII electron ID is added

ae5a734

cmsbuild added this to the CMSSW_12_6_X milestone Oct 25, 2022

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending xpog-pending labels Oct 25, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 25, 2022

cmsbuild mentioned this pull request Oct 25, 2022

NANO configuration Cleanup #39796

Merged

3 tasks

swagata87 mentioned this pull request Oct 25, 2022

Electron cut-based ID for Run3 from EGamma PR #39759

Closed

RunIII electron ID is added + new effArea

b6beb5b

cmsbuild added code-checks-pending and removed code-checks-approved labels Oct 25, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 25, 2022

swertz reviewed Oct 27, 2022

View reviewed changes

cmsbuild added the egamma label Oct 28, 2022

cmsbuild mentioned this pull request Oct 29, 2022

Photon MVA-based ID for Run3 from EGamma POG #39927

Merged

cmsbuild mentioned this pull request Nov 2, 2022

Cut based photon id run iii winter22 #39963

Merged

cmsbuild mentioned this pull request Nov 3, 2022

Adding MVA ID to nanoAOD code #39355

Merged

cmsbuild added tests-started and removed tests-pending labels Nov 3, 2022

cmsbuild added tests-pending and removed tests-started labels Nov 7, 2022

cmsbuild added tests-started and removed tests-pending labels Nov 7, 2022

cmsbuild added tests-rejected and removed tests-started labels Nov 7, 2022

cmsbuild mentioned this pull request Nov 9, 2022

HLT_Mu17_Photon30_IsoCaloId_v trigger filters backport to CMSSW_12_4_X #40034

Closed

rgoldouz mentioned this pull request Nov 10, 2022

Run3 ele ID is added to the cleaned 126 nanoAOD electron module + DQM (Run3 EffArea is applied only to the EGamma supported variables) #40045

Merged

rgoldouz closed this Nov 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run iii electron cut based #39839

Run iii electron cut based #39839

rgoldouz commented Oct 25, 2022

cmsbuild commented Oct 25, 2022

cmsbuild commented Oct 25, 2022

swagata87 commented Oct 25, 2022

swertz commented Oct 25, 2022

rgoldouz commented Oct 25, 2022

cmsbuild commented Oct 25, 2022

cmsbuild commented Oct 25, 2022

swertz Oct 27, 2022

swagata87 Oct 28, 2022

swagata87 commented Oct 28, 2022

rgoldouz commented Nov 1, 2022

swertz commented Nov 2, 2022

clacaputo commented Nov 3, 2022

mandrenguyen commented Nov 7, 2022

mandrenguyen commented Nov 7, 2022

cmsbuild commented Nov 7, 2022

swertz commented Nov 7, 2022 •

edited

Run iii electron cut based #39839

Run iii electron cut based #39839

Conversation

rgoldouz commented Oct 25, 2022

PR description:

cmsbuild commented Oct 25, 2022

cmsbuild commented Oct 25, 2022

swagata87 commented Oct 25, 2022

swertz commented Oct 25, 2022

rgoldouz commented Oct 25, 2022

cmsbuild commented Oct 25, 2022

cmsbuild commented Oct 25, 2022

swertz Oct 27, 2022

Choose a reason for hiding this comment

swagata87 Oct 28, 2022

Choose a reason for hiding this comment

swagata87 commented Oct 28, 2022

rgoldouz commented Nov 1, 2022

swertz commented Nov 2, 2022

clacaputo commented Nov 3, 2022

mandrenguyen commented Nov 7, 2022

mandrenguyen commented Nov 7, 2022

cmsbuild commented Nov 7, 2022

RelVals-INPUT

RelVals-NANO

Comparison Summary

swertz commented Nov 7, 2022 • edited

swertz commented Nov 7, 2022 •

edited