New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nano: fix matching between pat trigger objects and L1 objects #39893
Nano: fix matching between pat trigger objects and L1 objects #39893
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39893/32811
|
A new Pull Request was created by @swertz (Sébastien Wertz) for master. It involves the following packages:
@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
enable nano |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59ec10/28590/summary.html Comparison SummarySummary:
NANO Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
Nano size comparison Summary:
|
+1 Only differences are seen in trigObj L1/L2 variables, as expected. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Fix bug with matching between PAT trigger objects and L1 objects reported in #39809.
PR validation:
Ran with
runTheMatrix.py --what nano --site "" --command "--number 10"
. Differences in trigger object L1/L2 branches are expected.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Will backport to 124X. Similarly to #39309, #39230 and #39818, this will introduce some differences wrt previously produced nanoV10 samples (both when running in 126X and 124X), but we (XPOG) think the gain of fixing those in prompt nano outweights the cost of introducing these differences. Further, more cleanup on the TriggerObjectTableProducer is planned.