HLT menu development for `12_4_X` (10/N): HLT V1.5 of 2022 [`12_6_X`] #39924

missirol · 2022-10-29T17:39:14Z

PR description:

Development of HLT menus for CMSSW_12_4_X.

This version of the GRun HLT menu corresponds to "HLT V1.5" for 2022 pp data-taking.

Additionally, the HIon L1T menu used in HLT-specific tests is updated to the candidate L1T menu for the HIon 2022 test run (CMSLITDPG-1015): L1Menu_CollisionsHeavyIons2022_v1_1_0 (tag in CondDB).

Due to the update of the HIon menu, the DIGIHI2018PPRECO RelVal step is moved to the Fake2 HLT menu (like other Run-2 wfs); this affects wfs 158.{0,1,2,3,5}, whose DQM sequences already expect a "fake" HLT. These wfs were using the HIon HLT menu, which, after this PR, is not compatible anymore with the L1T menu in auto:phase1_2018_realistic_hi.

This is the PR for the master branch, which will then be backported to 12_5_X and 12_4_X (the latter is the release cycle currently used for HLT-menu development for Run 3).

It also includes 9f0a465, which changes of the frozen GRun menu in 12_6_X from "V1.4" to "V1.5"; this change will not be backported (the GRun frozen menus in 12_4_X and 12_5_X remain unchanged).

This PR includes the integration of the following JIRA tickets.

CMSHLT-2366: [BTV] disable DeepCSV triggers of GRun
CMSHLT-2476: [TSG] seed of HLT_EphemeralZeroBias changed to L1_ZeroBias_copy
CMSHLT-2478: [MUO] removed some HLT-muon modules from suppressWarning list
CMSHLT-2491: [TSG] update PSs of HLT_HT300_Beamspot trigger
CMSHLT-2495: [TSG] update PSs of Ephemeral triggers
CMSHLT-2497: [TSG] added L1T seed to HLT_EphemeralPhysics (L1A Physics "masking" L1_ZeroBias_copy)
CMSHLT-2499: [TSG] added L1_SingleTau130er2p1 to L1T seeds using L1_SingleTau120er2p1
CMSHLT-2501: [EXO] added L1Tau-seeded delayed-jet triggers
CMSHLT-2514: [TSG] disable two displaced-dijet and two PNET triggers
CMSHLT-2518: [HIG] update of 1 L1T seed and 2 PSs of MSSM-Hbb control triggers
CMSHLT-2519: [TSG] disable 4 fatjet softdrop-mass triggers plus other PS changes
CMSHLT-2520: [BTV] updated PSs of BTagMu triggers
CMSHLT-2521: [HIN] update of HIon sequences for RawPrime repacking
CMSHLT-2523: [HIN] removed outdated HIon triggers
CMSHLT-2527: [EXO] updated L1T seed of SingleLLPJet triggers
CMSHLT-2532: [HIN] update of Streams/PDs/EventContents for HIon 2022 test run
CMSHLT-2534: [JME] doubled PS of AlCa_*PFJet* triggers
CMSHLT-2535: [HIN] updated L1T seeds of HIUPC triggers
CMSHLT-2537: [TSG] sync PSs of offline menu with V1.4.5 online menu
CMSHLT-2539: [TSG] use common PF-scouting sequence in MC_Run3_PFScoutingPixelTracking_v Path

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_12_4_X
CMSSW_12_5_X

cmsbuild · 2022-10-29T17:46:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39924/32846

This PR adds an extra 828KB to repository

cmsbuild · 2022-10-29T17:46:32Z

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

Configuration/HLT (hlt)
HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

missirol · 2022-10-29T17:48:31Z

enable gpu

missirol · 2022-10-29T17:48:41Z

please test

cmsbuild · 2022-10-29T21:05:19Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e1ce6/28635/summary.html
COMMIT: 9f0a465
CMSSW: CMSSW_12_6_X_2022-10-29-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39924/28635/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

158.2158.2_PhotonJets_Pt_10_13_HI+PhotonJets_Pt_10_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_PhotonJets_Pt_10_13_HI+PhotonJets_Pt_10_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO.log
158.1158.1_QCD_Pt_80_120_13_HI+QCD_Pt_80_120_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_QCD_Pt_80_120_13_HI+QCD_Pt_80_120_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO.log
158.3158.3_ZEEMM_13_HI+ZEEMM_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_ZEEMM_13_HI+ZEEMM_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO.log

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3416118
DQMHistoTests: Total failures: 477
DQMHistoTests: Total nulls: 6
DQMHistoTests: Total successes: 3415613
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 9.701999999999998 KiB( 47 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 1.386 KiB HLT/Filters
Checked 206 log files, 48 edm output root files, 48 DQM output files
TriggerResults: found differences in 1 / 46 workflows

GPU Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19876
DQMHistoTests: Total failures: 24
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19852
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

cmsbuild · 2022-10-30T06:26:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39924/32853

This PR adds an extra 868KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): NANO configuration Cleanup #39796, Add new HI Beamspot to the Run-3 HI MC + change vertex smearing to use the estimated HI version #39758, Raw prime wf for Run 3 data w/ dropped strips + approx. clusters #39863

cmsbuild · 2022-10-30T06:26:46Z

Pull request #39924 was updated. @Martin-Grunewald, @AdrianoDee, @bbilin, @cmsbuild, @missirol, @srimanob, @kskovpen, @sunilUIET can you please check and sign again.

missirol · 2022-10-30T06:31:59Z

please test

The DIGIHI2018PPRECO RelVal step is moved to the Fake2 HLT menu (like other Run-2 wfs); this affects wfs 158.{0,1,2,3,5}, whose DQM sequences already expect a "fake" HLT. These wfs were using the HIon HLT menu, which, after this PR, is not compatible anymore with the L1T menu in auto:phase1_2018_realistic_hi. This now requires the signature of @cms-sw/pdmv-l2 and @cms-sw/upgrade-l2.

cmsbuild · 2022-10-30T15:46:36Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e1ce6/28640/summary.html
COMMIT: 99290c6
CMSSW: CMSSW_12_6_X_2022-10-30-0000/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39924/28640/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3416118
DQMHistoTests: Total failures: 474
DQMHistoTests: Total nulls: 6
DQMHistoTests: Total successes: 3415616
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 9.701999999999998 KiB( 47 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 1.386 KiB HLT/Filters
Checked 206 log files, 48 edm output root files, 48 DQM output files
TriggerResults: found differences in 1 / 46 workflows

GPU Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19876
DQMHistoTests: Total failures: 22
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19854
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

missirol · 2022-10-30T16:29:27Z

+hlt

differences in the outputs of PR tests are in line with updates to the HLT GRun menu

srimanob · 2022-10-31T02:11:25Z

+Upgrade

From Configuration/PyReleaseValidation, the change is to use Fake2 menu, instead of HIon menu with 2018 HIon data.

missirol · 2022-10-31T08:18:15Z

@cms-sw/pdmv-l2 , please have a look at this PR (and backports). A 1-line change in Configuration/PyReleaseValidation requires your signature.

It would be good if we could merge this PR in time for the next IB.

kskovpen · 2022-10-31T08:38:25Z

+pdmv

cmsbuild · 2022-10-31T08:38:45Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

missirol · 2022-10-31T09:41:37Z

@cms-sw/orp-l2

It would be good to merge this PR in time for the next IB. Please consider it.

perrotta · 2022-10-31T10:04:48Z

+1

perrotta · 2022-10-31T10:06:37Z

@cms-sw/orp-l2

It would be good to merge this PR in time for the next IB. Please consider it.

Missed by a few minutes... but I'm in vacation (tomorrow is holiday in Italy), I think that having it for this evening IB can be still accepted ;-)

missirol · 2022-10-31T10:08:15Z

Of course, no problem. I tried :)

missirol added 2 commits October 29, 2022 17:04

HLT menu development for 12_4_X (branch: 12_6_X)

b3f7187

Update of frozen GRun menu to HLT 2022-V1.5

9f0a465

cmsbuild added this to the CMSSW_12_6_X milestone Oct 29, 2022

cmsbuild added code-checks-pending hlt-pending orp-pending pending-signatures tests-pending labels Oct 29, 2022

This was referenced Oct 29, 2022

HLT menu development for 12_4_X (10/N): HLT V1.5 of 2022 [12_5_X] #39925

Merged

HLT menu development for 12_4_X (10/N): HLT V1.5 of 2022 #39926

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 29, 2022

cmsbuild added tests-started and removed tests-pending labels Oct 29, 2022

cmsbuild added tests-rejected and removed tests-started labels Oct 29, 2022

move DIGIHI2018PPRECO RelVal step to Fake2 HLT menu

99290c6

cmsbuild added code-checks-pending pdmv-pending tests-pending upgrade-pending and removed tests-rejected code-checks-approved labels Oct 30, 2022

cmsbuild removed the code-checks-pending label Oct 30, 2022

cmsbuild added tests-started and removed tests-pending labels Oct 30, 2022

cmsbuild added tests-approved and removed tests-started labels Oct 30, 2022

cmsbuild added hlt-approved and removed hlt-pending labels Oct 30, 2022

cmsbuild added upgrade-approved and removed upgrade-pending labels Oct 31, 2022

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Oct 31, 2022

cmsbuild added orp-approved and removed orp-pending labels Oct 31, 2022

cmsbuild merged commit 01003c8 into cms-sw:master Oct 31, 2022

missirol deleted the HLTdevelopment124X_for126X branch October 31, 2022 10:07

This was referenced Oct 31, 2022

[MkFit] Phase2 geometry & String configurable standard functions #39866

Merged

Introduction of New-All-In-One tool for Offline Validation of TrkAlignment #38304

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HLT menu development for `12_4_X` (10/N): HLT V1.5 of 2022 [`12_6_X`] #39924

HLT menu development for `12_4_X` (10/N): HLT V1.5 of 2022 [`12_6_X`] #39924

missirol commented Oct 29, 2022 •

edited

cmsbuild commented Oct 29, 2022

cmsbuild commented Oct 29, 2022

missirol commented Oct 29, 2022

missirol commented Oct 29, 2022

cmsbuild commented Oct 29, 2022

cmsbuild commented Oct 30, 2022

cmsbuild commented Oct 30, 2022

missirol commented Oct 30, 2022

cmsbuild commented Oct 30, 2022

missirol commented Oct 30, 2022

srimanob commented Oct 31, 2022

missirol commented Oct 31, 2022

kskovpen commented Oct 31, 2022

cmsbuild commented Oct 31, 2022

missirol commented Oct 31, 2022

perrotta commented Oct 31, 2022

perrotta commented Oct 31, 2022

missirol commented Oct 31, 2022

HLT menu development for 12_4_X (10/N): HLT V1.5 of 2022 [12_6_X] #39924

HLT menu development for 12_4_X (10/N): HLT V1.5 of 2022 [12_6_X] #39924

Conversation

missirol commented Oct 29, 2022 • edited

PR description:

PR validation:

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

cmsbuild commented Oct 29, 2022

cmsbuild commented Oct 29, 2022

missirol commented Oct 29, 2022

missirol commented Oct 29, 2022

cmsbuild commented Oct 29, 2022

RelVals-INPUT

Comparison Summary

GPU Comparison Summary

cmsbuild commented Oct 30, 2022

cmsbuild commented Oct 30, 2022

missirol commented Oct 30, 2022

cmsbuild commented Oct 30, 2022

Comparison Summary

GPU Comparison Summary

missirol commented Oct 30, 2022

srimanob commented Oct 31, 2022

missirol commented Oct 31, 2022

kskovpen commented Oct 31, 2022

cmsbuild commented Oct 31, 2022

missirol commented Oct 31, 2022

perrotta commented Oct 31, 2022

perrotta commented Oct 31, 2022

missirol commented Oct 31, 2022

HLT menu development for `12_4_X` (10/N): HLT V1.5 of 2022 [`12_6_X`] #39924

HLT menu development for `12_4_X` (10/N): HLT V1.5 of 2022 [`12_6_X`] #39924

missirol commented Oct 29, 2022 •

edited