TkDQM: Add DQM modules for monitoring VectorHits #39962

sroychow · 2022-11-02T15:22:33Z

PR description:

Work done by @gsaha009 to introduce DQM modules to monitor VectorHits. Two collections of vector hits are monitored - accepted and rejected.

PR validation:

Wf 20834.9 runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported

NA

cmsbuild · 2022-11-02T16:03:03Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39962/32891

This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39962/32891/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39962/32891/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-11-02T17:32:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39962/32895

This PR adds an extra 16KB to repository

cmsbuild · 2022-11-02T17:32:45Z

A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master.

It involves the following packages:

DQM/SiTrackerPhase2 (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @mmusich, @sroychow this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

mmusich · 2022-11-02T17:36:34Z

test parameters:

relvals_opt= -w upgrade
workflows = 20834.9, 21034.9

mmusich · 2022-11-02T17:54:15Z

please test

cmsbuild · 2022-11-02T22:13:55Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-196d42/28757/summary.html
COMMIT: f750dbe
CMSSW: CMSSW_12_6_X_2022-11-02-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39962/28757/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-196d42/20834.9_TTbar_14TeV+2026D88_vectorHits+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal+ALCAPhase2
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-196d42/21034.9_TTbar_14TeV+2026D88PU_vectorHits+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3603590
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3603562
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 111329.876 KiB( 49 files compared)
DQMHistoSizes: changed ( 20834.9,... ): 27832.469 KiB TrackerPhase2OTVectorHits/Accepted
DQMHistoSizes: changed ( 20834.9,... ): 27832.469 KiB TrackerPhase2OTVectorHits/Rejected
Checked 215 log files, 52 edm output root files, 50 DQM output files
TriggerResults: no differences found

DQM/SiTrackerPhase2/plugins/Phase2OTMonitorVectorHits.cc

mmusich · 2022-11-03T13:30:27Z

DQM/SiTrackerPhase2/python/Phase2TrackerDQMFirstStep_cff.py

+trackerphase2DQMSource_wVhits = cms.Sequence( pixDigiMon
+                                       + otDigiMon
+                                       +rechitMonitorIT
+                                       + clusterMonitorIT
+                                       + clusterMonitorOT
+                                       + acceptedVecHitsmon
+                                       + rejectedVecHitsmon
+)


Suggested change

trackerphase2DQMSource_wVhits = cms.Sequence( pixDigiMon

+ otDigiMon

+rechitMonitorIT

+ clusterMonitorIT

+ clusterMonitorOT

+ acceptedVecHitsmon

+ rejectedVecHitsmon

)

trackerphase2DQMSource_wVhits = trackerphase2DQMSource.copy()

trackerphase2DQMSource_wVhits += cms.Sequence(acceptedVecHitsmon +rejectedVecHitsmon)

is more compact and should be equivalent.

cmsbuild · 2022-11-09T11:05:53Z

Pull request #39962 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

cmsbuild · 2022-11-09T11:41:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39962/32979

This PR adds an extra 16KB to repository

cmsbuild · 2022-11-09T11:41:29Z

Pull request #39962 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

mmusich · 2022-11-09T11:44:42Z

please test

cmsbuild · 2022-11-09T21:29:35Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-196d42/28923/summary.html
COMMIT: 5ce1b65
CMSSW: CMSSW_12_6_X_2022-11-09-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39962/28923/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-196d42/20834.9_TTbar_14TeV+2026D88_vectorHits+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal+ALCAPhase2
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-196d42/21034.9_TTbar_14TeV+2026D88PU_vectorHits+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3603639
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3603614
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 111554.922 KiB( 49 files compared)
DQMHistoSizes: changed ( 20834.9,... ): 27888.730 KiB TrackerPhase2OTVectorHits/Accepted
DQMHistoSizes: changed ( 20834.9,... ): 27888.730 KiB TrackerPhase2OTVectorHits/Rejected
Checked 215 log files, 52 edm output root files, 50 DQM output files
TriggerResults: no differences found

emanueleusai · 2022-11-12T01:33:25Z

This adds about 110MB of histogram memory, about 1090 monitoring elements. Are they all necessary?

mmusich · 2022-11-16T00:36:49Z

@emanueleusai

This adds about 110MB of histogram memory, about 1090 monitoring elements. Are they all necessary?

These histograms are added only in the workflows running the vector hits reconstruction (a very limited subset of the full matrix, activated by the seedingDeepCore modifier).
They are needed now during the development/commissioning phase and will be removed/merged with the regular OT monitoring once that is over.

emanueleusai · 2022-11-16T00:37:56Z

@mmusich thank you very much for the clarification

emanueleusai · 2022-11-16T00:38:20Z

+1

cmsbuild · 2022-11-16T00:38:38Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2022-11-16T13:11:20Z

+1

add vechit monitor

5c2b63b

cmsbuild added this to the CMSSW_12_6_X milestone Nov 2, 2022

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Nov 2, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Nov 2, 2022

code format

f750dbe

cmsbuild added code-checks-pending and removed code-checks-rejected labels Nov 2, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 2, 2022

cmsbuild added tests-started and removed tests-pending labels Nov 2, 2022

cmsbuild added tests-approved and removed tests-started labels Nov 2, 2022

mmusich reviewed Nov 3, 2022

View reviewed changes

DQM/SiTrackerPhase2/plugins/Phase2OTMonitorVectorHits.cc Show resolved Hide resolved

DQM/SiTrackerPhase2/plugins/Phase2OTMonitorVectorHits.cc Show resolved Hide resolved

DQM/SiTrackerPhase2/plugins/Phase2OTMonitorVectorHits.cc Show resolved Hide resolved

mmusich reviewed Nov 3, 2022

View reviewed changes

add additional variables to monitor

4be4183

cmsbuild added code-checks-pending and removed tests-approved code-checks-approved labels Nov 9, 2022

cmsbuild added the code-checks-approved label Nov 9, 2022

update config

5ce1b65

cmsbuild added code-checks-pending and removed code-checks-approved labels Nov 9, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 9, 2022

cmsbuild added tests-started and removed tests-pending labels Nov 9, 2022

cmsbuild added tests-approved and removed tests-started labels Nov 9, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Nov 16, 2022

cmsbuild added orp-approved and removed orp-pending labels Nov 16, 2022

cmsbuild merged commit 19f708f into cms-sw:master Nov 16, 2022

This was referenced Nov 17, 2022

[ROOT626] Updated root to tip of branch v6-26-00-patches cms-sw/cmsdist#8179

Closed

[MkFit] Phase2 geometry & String configurable standard functions #39866

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TkDQM: Add DQM modules for monitoring VectorHits #39962

TkDQM: Add DQM modules for monitoring VectorHits #39962

sroychow commented Nov 2, 2022

cmsbuild commented Nov 2, 2022

cmsbuild commented Nov 2, 2022

cmsbuild commented Nov 2, 2022

mmusich commented Nov 2, 2022 •

edited

mmusich commented Nov 2, 2022

cmsbuild commented Nov 2, 2022

mmusich Nov 3, 2022

cmsbuild commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

mmusich commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

emanueleusai commented Nov 12, 2022

mmusich commented Nov 16, 2022 •

edited

emanueleusai commented Nov 16, 2022

emanueleusai commented Nov 16, 2022

cmsbuild commented Nov 16, 2022

rappoccio commented Nov 16, 2022

TkDQM: Add DQM modules for monitoring VectorHits #39962

TkDQM: Add DQM modules for monitoring VectorHits #39962

Conversation

sroychow commented Nov 2, 2022

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported

cmsbuild commented Nov 2, 2022

cmsbuild commented Nov 2, 2022

cmsbuild commented Nov 2, 2022

mmusich commented Nov 2, 2022 • edited

mmusich commented Nov 2, 2022

cmsbuild commented Nov 2, 2022

Comparison Summary

mmusich Nov 3, 2022

Choose a reason for hiding this comment

cmsbuild commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

mmusich commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

Comparison Summary

emanueleusai commented Nov 12, 2022

mmusich commented Nov 16, 2022 • edited

emanueleusai commented Nov 16, 2022

emanueleusai commented Nov 16, 2022

cmsbuild commented Nov 16, 2022

rappoccio commented Nov 16, 2022

mmusich commented Nov 2, 2022 •

edited

mmusich commented Nov 16, 2022 •

edited