Remove MVASelector tags for tracking in MC GTs #40010

tvami · 2022-11-07T19:28:04Z

PR description:

Remove MVASelector tags for tracking as requested in https://cms-talk.web.cern.ch/t/proposal-of-removal-of-bdt-based-gbrwrapperrcd-tags-for-tracking-selection-from-run-3-globaltags/16757

This is the MC part, we expect no changes in the relval test.
I also created the data GTs but bc we need to re-snapshot I'll do another PR to integrate in CMSSW.

PR validation:

test parameters:
  - workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, no backport needed, maybe to 12_5_X for good GT naming

tvami · 2022-11-07T19:28:33Z

test parameters:

workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

cmsbuild · 2022-11-07T19:33:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40010/32952

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/AlCa/python/autoCond.py modified in PR(s): Update Run3 offline and offline_relval GTs #39823

cmsbuild · 2022-11-07T19:34:05Z

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

Configuration/AlCa (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

tvami · 2022-11-07T19:51:44Z

@cmsbuild , please test

cmsbuild · 2022-11-07T19:58:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40010/32955

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/AlCa/python/autoCond.py modified in PR(s): Update Run3 offline and offline_relval GTs #39823

cmsbuild · 2022-11-07T19:58:31Z

Pull request #40010 was updated. @malbouis, @yuanchao, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

cmsbuild · 2022-11-07T23:35:12Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66d2d9/28839/summary.html
COMMIT: fbf70d9
CMSSW: CMSSW_12_6_X_2022-11-07-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40010/28839/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@Dr15Jones Set member data in GEMClusterProcessor #39990
@francescobrivio Add ppEra_Run3_pp_on_PbPb_approxSiStripClusters scenario #39998
@bsunanda Phase2-hgx327G Remove and modify many more test scripts in Geometry/HGCalCommonData in view of retaining only stuffs for V16, V17 and TB #39972

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66d2d9/28839/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66d2d9/28839/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/pool/condor/dir_3787/jenkins/workspace/compare-root-files-short-matrix/data/PR-66d2d9/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
/pool/condor/dir_3787/jenkins/workspace/compare-root-files-short-matrix/data/PR-66d2d9/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 52
DQMHistoTests: Total histograms compared: 3867715
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3867690
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
Checked 225 log files, 48 edm output root files, 52 DQM output files
TriggerResults: no differences found

mmusich · 2022-11-08T10:12:38Z

test parameters:

workflows = 159,159.02,159.03,140.56,140.58,140.6

mmusich · 2022-11-08T10:12:45Z

please test

tvami · 2022-11-10T13:46:08Z

@francescobrivio I updated the PR desc, and force pushed, now the design MC GT looks good too

tvami · 2022-11-10T13:46:14Z

@cmsbuild , please test

cmsbuild · 2022-11-10T13:52:45Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40010/32998

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/AlCa/python/autoCond.py modified in PR(s): Update Run3 offline and offline_relval GTs #39823, Remove MVASelector tags for tracking in data GTs + re-snapshot frozen GT #40011, HLT_Mu17_Photon30_IsoCaloId_v trigger filters backport to CMSSW_12_4_X #40034

cmsbuild · 2022-11-10T13:53:16Z

Pull request #40010 was updated. @malbouis, @yuanchao, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

francescobrivio · 2022-11-10T13:59:05Z

unhold

Remove MVASelector tags for tracking in MC GTs #40010 (comment) addressed in 6858ef8

cmsbuild · 2022-11-10T17:53:58Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66d2d9/28950/summary.html
COMMIT: 6858ef8
CMSSW: CMSSW_12_6_X_2022-11-09-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40010/28950/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-66d2d9/140.58_RunHI2018+RunHI2018+RAWPRIMEHI18+RECOHID18APPROXCLUSTERS+HARVESTDHI18
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-66d2d9/140.6_RunHI2022+RunHI2022+RAWPRIMEHI22+RECOHID22APPROXCLUSTERS+HARVESTDHI22
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-66d2d9/159.02_HydjetQ_B12_5020GeV_2021_ppReco+HydjetQ_B12_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RAWPRIMESIMHI18+RECOHI2021PPRECOMBAPPROXCLUSTERS+ALCARECOHI2021PPRECO+HARVESTHI2021PPRECO4
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-66d2d9/159.03_HydjetQ_MinBias_5020GeV_2021_ppReco+HydjetQ_MinBias_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RAWPRIMESIMHI18+RECOHI2022PROD+MINIHI2022PROD

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 52
DQMHistoTests: Total histograms compared: 3717949
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3717927
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
Checked 230 log files, 48 edm output root files, 52 DQM output files
TriggerResults: no differences found

malbouis · 2022-11-10T18:59:45Z

+alca

cmsbuild · 2022-11-10T19:00:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2022-11-10T21:34:53Z

+1

Review converged on this one, working as described.

cmsbuild added this to the CMSSW_12_6_X milestone Nov 7, 2022

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Nov 7, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 7, 2022

tvami force-pushed the RemoveTrackingMVAtags branch from 06a34cb to 1c18b7a Compare November 7, 2022 19:49

cmsbuild added code-checks-pending and removed code-checks-approved labels Nov 7, 2022

tvami force-pushed the RemoveTrackingMVAtags branch from 1c18b7a to fbf70d9 Compare November 7, 2022 19:50

cmsbuild added tests-started and removed tests-pending labels Nov 7, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 7, 2022

tvami mentioned this pull request Nov 7, 2022

Remove MVASelector tags for tracking in data GTs + re-snapshot frozen GT #40011

Merged

cmsbuild added tests-approved and removed tests-started labels Nov 7, 2022

cmsbuild added tests-started and removed tests-approved labels Nov 8, 2022

cmsbuild added alca-pending code-checks-pending tests-pending and removed code-checks-approved labels Nov 10, 2022

cmsbuild added tests-started and removed tests-pending labels Nov 10, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 10, 2022

cmsbuild removed the hold label Nov 10, 2022

cmsbuild added tests-approved and removed tests-started labels Nov 10, 2022

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Nov 10, 2022

cmsbuild added orp-approved and removed orp-pending labels Nov 10, 2022

cmsbuild merged commit e9da5e5 into cms-sw:master Nov 10, 2022

This was referenced Nov 14, 2022

Remove tracking BDT based tags from Run-3 GTs cms-AlCaDB/AlCaTools#81

Open

[125X] Remove tracking MVA tags from Run-3 MC and data GTs #40078

Merged

francescobrivio mentioned this pull request Jan 7, 2023

Update GTs for 2023 #40445

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove MVASelector tags for tracking in MC GTs #40010

Remove MVASelector tags for tracking in MC GTs #40010

tvami commented Nov 7, 2022 •

edited

tvami commented Nov 7, 2022

cmsbuild commented Nov 7, 2022

cmsbuild commented Nov 7, 2022

tvami commented Nov 7, 2022

cmsbuild commented Nov 7, 2022

cmsbuild commented Nov 7, 2022

cmsbuild commented Nov 7, 2022

mmusich commented Nov 8, 2022

mmusich commented Nov 8, 2022

tvami commented Nov 10, 2022

tvami commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

francescobrivio commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

malbouis commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

rappoccio commented Nov 10, 2022

Remove MVASelector tags for tracking in MC GTs #40010

Remove MVASelector tags for tracking in MC GTs #40010

Conversation

tvami commented Nov 7, 2022 • edited

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

tvami commented Nov 7, 2022

cmsbuild commented Nov 7, 2022

cmsbuild commented Nov 7, 2022

tvami commented Nov 7, 2022

cmsbuild commented Nov 7, 2022

cmsbuild commented Nov 7, 2022

cmsbuild commented Nov 7, 2022

Comparison Summary

mmusich commented Nov 8, 2022

mmusich commented Nov 8, 2022

tvami commented Nov 10, 2022

tvami commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

francescobrivio commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

Comparison Summary

malbouis commented Nov 10, 2022

cmsbuild commented Nov 10, 2022

rappoccio commented Nov 10, 2022

tvami commented Nov 7, 2022 •

edited