Tau discrimination producers (not yet) stream

[VinInn]

trivial change to make it thread safe
for the Producer itself we need to wait MVA to go in DB

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_2_X.

Tau discrimination producers (not yet) stream

It involves the following packages:

RecoTauTag/RecoTau

@nclopezo, @cmsbuild, @thspeer, @StoyanStoynev, @slava77, @Degano can you please review it and eventually sign? Thanks.
@jpavel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[cmsbuild]

Pull request #4020 was updated. @nclopezo, @cmsbuild, @thspeer, @StoyanStoynev, @slava77, @Degano can you please check and sign again.

[slava77]

Does it make sense to define this somewhere "centrally"?
This is not the only place where exactly the same vector is computed
git grep 2.97025

RecoParticleFlow/PFClusterProducer/src/SpikeAndDoubleSpikeCleaner.cc:    constexpr double cPhi[18] = {2.97025, 2.621184149601134, 2.272118299202268,
RecoParticleFlow/PFClusterTools/src/PFEnergyCalibration.cc:    retValue[0]=2.97025;
RecoParticleFlow/PFClusterTools/src/PFResolutionMap.cc:  cPhi[0]=2.97025;
RecoParticleFlow/PFProducer/src/PFElectronAlgo.cc:        float mphi=-2.97025;
RecoTauTag/RecoTau/src/AntiElectronIDMVA5GBR.cc:    cPhi[0] = 2.97025;

[VinInn]

good point:
@jpavel: something else to take care

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4020/25/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4020/25/summary.html

[slava77]

+1

for #4020 58b822d
no diffs from jenkins

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).