Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_6_X] Nano: restore Run2/3 consistency between electron/photon IDs; remove scale+smearing correction for Run3 #40224

Merged

Conversation

swertz
Copy link
Contributor

@swertz swertz commented Dec 2, 2022

PR description:

Backport of #40209, see description there

PR validation:

Same as #40209

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport needed for nanoAODv11 production in 12_6_X.

@swertz
Copy link
Contributor Author

swertz commented Dec 2, 2022

enable nano

@swertz
Copy link
Contributor Author

swertz commented Dec 2, 2022

type egamma

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

A new Pull Request was created by @swertz (Sbastien Wertz) for CMSSW_12_6_X.

It involves the following packages:

  • Configuration/Eras (operations)
  • PhysicsTools/NanoAOD (xpog)

@perrotta, @rappoccio, @swertz, @vlimant, @cmsbuild, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @missirol, @gpetruc, @fabiocos, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@swertz
Copy link
Contributor Author

swertz commented Dec 2, 2022

please test

@swertz swertz changed the title [12_6_X] Nano: restore consistency Run2/3 consistency between electron/photon IDs; remove scale+smearing correction for Run3 [12_6_X] Nano: restore Run2/3 consistency between electron/photon IDs; remove scale+smearing correction for Run3 Dec 2, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27b324/29427/summary.html
COMMIT: dfb9b8f
CMSSW: CMSSW_12_6_X_2022-12-02-1100/el8_amd64_gcc10
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40224/29427/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 211 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416625
  • DQMHistoTests: Total failures: 36
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416567
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -66.637 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -8.153 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): -4.783 KiB Physics/NanoAODDQM
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 204 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 15138
  • DQMHistoTests: Total failures: 88
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 15050
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -65.27 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.311,... ): -1.524 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.331,... ): -0.738 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.401,... ): -8.153 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.511,... ): -4.783 KiB Physics/NanoAODDQM
  • Checked 31 log files, 14 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.190 2.213 -0.023 ( -1.0% ) 9.05 8.81 +2.7% 1.580 1.577
2500.311 2.312 2.334 -0.022 ( -1.0% ) 8.80 8.48 +3.7% 1.946 1.934
2500.312 2.264 2.288 -0.023 ( -1.0% ) 9.14 8.64 +5.7% 1.933 1.945
2500.33 1.083 1.103 -0.020 ( -1.8% ) 21.58 19.72 +9.4% 1.694 1.696
2500.331 1.379 1.403 -0.024 ( -1.7% ) 15.90 14.64 +8.6% 1.837 1.840
2500.332 1.312 1.336 -0.024 ( -1.8% ) 17.54 16.42 +6.8% 1.804 1.802
2500.4 2.097 2.109 -0.012 ( -0.6% ) 9.85 9.44 +4.3% 1.480 1.472
2500.401 2.135 2.136 -0.000 ( -0.0% ) 9.89 9.45 +4.6% 1.291 1.284
2500.5 1.668 1.680 -0.012 ( -0.7% ) 15.28 14.49 +5.5% 1.189 1.186
2500.501 1.705 1.707 -0.002 ( -0.1% ) 15.74 14.33 +9.8% 1.195 1.206
2500.51 1.071 1.075 -0.003 ( -0.3% ) 28.42 25.97 +9.4% 1.485 1.478
2500.511 1.113 1.107 0.006 ( +0.5% ) 27.88 25.61 +8.9% 1.507 1.512
2500.6 2.006 2.018 -0.012 ( -0.6% ) 12.53 11.71 +7.0% 1.258 1.247
2500.601 2.045 2.047 -0.001 ( -0.1% ) 12.62 11.70 +7.9% 1.260 1.266

@swertz
Copy link
Contributor Author

swertz commented Dec 2, 2022

+1

Same changes as in #40209

@perrotta
Copy link
Contributor

perrotta commented Dec 3, 2022

backport of #40209

@cmsbuild cmsbuild added backport and removed backport labels Dec 3, 2022
@perrotta
Copy link
Contributor

perrotta commented Dec 3, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants