Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JMENanoAOD] Backport of #40232 (Setup DQM and increase precision of PileUp ID & QGL input variables) to 12_6_X #40247

Merged

Conversation

nurfikri89
Copy link
Contributor

Backport from #40232

Orignal PR description:

This PR updates the JMENano workflow to make the following changes:

  • Setup the DQM for JMENano. The DQM step name is nanojmeDQM.
  • Increase the precision for the PileUp ID and Quark-Gluon Likelihood input variables.
  • Add AK4 jet ParticleNet gluon raw score.
  • Bugfix related to JetID configurations in JMENano.

Backport PR validation:

  • passes the JMENano workflows: runTheMatrix.py -i all --ibeos -l 10224.15,11024.15,25202.15,11634.15

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2022

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for CMSSW_12_6_X.

It involves the following packages:

  • DQMOffline/Configuration (dqm)
  • PhysicsTools/NanoAOD (xpog)

@swertz, @vlimant, @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@gpetruc, @threus, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@swertz
Copy link
Contributor

swertz commented Dec 6, 2022

please test

1 similar comment
@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2022

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de47e9/29483/summary.html
COMMIT: c364147
CMSSW: CMSSW_12_6_X_2022-12-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40247/29483/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 1001.31001.3_RunSingleMuon2022B+RunSingleMuon2022B+TIER0EXPRUN3+ALCAEXPRUN3+ALCAHARVDEXPRUN3/step2_RunSingleMuon2022B+RunSingleMuon2022B+TIER0EXPRUN3+ALCAEXPRUN3+ALCAHARVDEXPRUN3.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416871
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416843
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@swertz
Copy link
Contributor

swertz commented Dec 7, 2022

please test

Trying again, error looks spurious

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de47e9/29496/summary.html
COMMIT: c364147
CMSSW: CMSSW_12_6_X_2022-12-06-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40247/29496/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416871
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416843
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@swertz
Copy link
Contributor

swertz commented Dec 7, 2022

Backport of #40232

@swertz
Copy link
Contributor

swertz commented Dec 7, 2022

+1

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 59006ab into cms-sw:CMSSW_12_6_X Dec 8, 2022
@nurfikri89 nurfikri89 deleted the portFrom130XTo126X_JMENanoV11_ForPR branch October 29, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants