Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport of PR #40230] Electron MVA-based ID for Run3 from EGamma POG #40250

Conversation

Prasant1993
Copy link
Contributor

@Prasant1993 Prasant1993 commented Dec 6, 2022

PR description:

Backport of PR #40230, see description there

PR validation:

Same as #40230

runTheMatrix.py --what nano --site "" -l 2500.312,2500.501

This PR needs to be tested with the PR cms-data/RecoEgamma-ElectronIdentification#27

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport required for nanoAODv11 production in 12_6_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2022

A new Pull Request was created by @Prasant1993 (Prasant Kumar Rout) for CMSSW_12_6_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/PatAlgos (xpog, reconstruction)
  • RecoEgamma/EgammaTools (reconstruction)
  • RecoEgamma/ElectronIdentification (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jainshilpi, @hatakeyamak, @emilbols, @Sam-Harper, @mbluj, @demuller, @varuns23, @seemasharmafnal, @mmarionncern, @jdolen, @ahinzmann, @lgray, @missirol, @azotz, @a-kapoor, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @AlexDeMoor, @AnnikaStein, @valsdav, @JyothsnaKomaragiri, @sobhatta, @afiqaize, @gpetruc, @wrtabb, @mariadalfonso, @sameasy, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@Prasant1993 Prasant1993 changed the title [Backport of PR #40230] Electron MVA based ID for Run3 from EGM POG [Backport of PR #40230] Electron MVA-based ID for Run3 from EGM POG Dec 6, 2022
@Prasant1993 Prasant1993 changed the title [Backport of PR #40230] Electron MVA-based ID for Run3 from EGM POG [Backport of PR #40230] Electron MVA-based ID for Run3 from EGamma POG Dec 6, 2022
@swertz
Copy link
Contributor

swertz commented Dec 6, 2022

enable nano

@swertz
Copy link
Contributor

swertz commented Dec 6, 2022

please test

@swertz
Copy link
Contributor

swertz commented Dec 6, 2022

backport of #40230

@swertz
Copy link
Contributor

swertz commented Dec 6, 2022

type egamma

@cmsbuild cmsbuild added the egamma label Dec 6, 2022
@swertz
Copy link
Contributor

swertz commented Dec 6, 2022

please abort

@swertz
Copy link
Contributor

swertz commented Dec 6, 2022

please test with cms-data/RecoEgamma-ElectronIdentification#27

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bc8a3/29489/summary.html
COMMIT: c028da1
CMSSW: CMSSW_12_6_X_2022-12-06-1100/el8_amd64_gcc10
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40250/29489/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bc8a3/29489/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bc8a3/29489/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 885 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416821
  • DQMHistoTests: Total failures: 32
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416767
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 13.781999999999998 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 1.658 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 1.088 KiB Physics/NanoAODDQM
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 32 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 15298
  • DQMHistoTests: Total failures: 66
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 15232
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 10.411 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.311,... ): -0.346 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.331,... ): -0.225 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.401,... ): 1.658 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.511,... ): 1.088 KiB Physics/NanoAODDQM
  • Checked 31 log files, 14 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.190 2.190 0.000 ( +0.0% ) 9.12 9.04 +0.8% 1.529 1.580
2500.311 2.312 2.312 0.000 ( +0.0% ) 8.75 8.55 +2.3% 1.893 1.948
2500.312 2.264 2.264 0.000 ( +0.0% ) 8.80 8.65 +1.8% 1.886 1.935
2500.33 1.083 1.083 0.000 ( +0.0% ) 21.27 20.73 +2.6% 1.692 1.694
2500.331 1.379 1.379 0.000 ( +0.0% ) 15.56 15.16 +2.6% 1.838 1.840
2500.332 1.312 1.312 0.000 ( +0.0% ) 17.48 16.85 +3.7% 1.794 1.796
2500.4 2.097 2.097 0.000 ( +0.0% ) 9.65 9.47 +1.9% 1.427 1.478
2500.401 2.145 2.135 0.010 ( +0.5% ) 9.82 9.62 +2.1% 1.225 1.290
2500.5 1.668 1.668 0.000 ( +0.0% ) 15.39 14.68 +4.8% 1.142 1.191
2500.501 1.712 1.705 0.007 ( +0.4% ) 15.46 14.81 +4.4% 1.155 1.209
2500.51 1.071 1.071 0.000 ( +0.0% ) 27.94 26.83 +4.2% 1.430 1.490
2500.511 1.122 1.113 0.009 ( +0.8% ) 27.30 26.69 +2.3% 1.455 1.513
2500.6 2.006 2.006 0.000 ( +0.0% ) 12.50 11.98 +4.3% 1.213 1.254
2500.601 2.055 2.045 0.010 ( +0.5% ) 12.46 12.02 +3.7% 1.210 1.259

@swertz
Copy link
Contributor

swertz commented Dec 7, 2022

+1

Same changes as in #40230

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

Will merge this when the IBs clear in the main branch.

@rappoccio
Copy link
Contributor

+1

IBs have cleared. Once this PR is tested in the next IBs we can cut 12_6, probably Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants