Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Alpaka ESProducer model by making the data copies to device implicit #40403

Merged
merged 3 commits into from Feb 3, 2023
Merged

Simplify Alpaka ESProducer model by making the data copies to device implicit #40403

merged 3 commits into from Feb 3, 2023

Commits on Feb 1, 2023

  1. Simplify Alpaka ESProducer model by making the data copies to device … 

    …implicit

Drop earlier "model 1" (where the re-formatted host ESProduct was not
really accessible for other purposes than the data copy), and rename
"model 3" to "model 1".

Use host ESProducts directly on host backends

Make host-side setWhatProduced to always register a copy to device

Replace TransferToHost class template specialization with copyToHost()
and copyToDevice() function overloads.

Add an example configuration that has a portable EDProducer and an
explicitly host-version of that.
    @makortel
    makortel committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    9ef5080 View commit details
    Browse the repository at this point in the history

  2. Add helper variables to simplify use-product-directly checks

    @makortel
    makortel committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    6355e95 View commit details
    Browse the repository at this point in the history

  3. Change data copy functions (back) to class template specialization 

    This approach is more verbose, but does not suffer from unexpected
behavior in a case where data product class inherits from another
class, and the copy function overload exists for the base class but
not for the derived class. With function overload the system would
copy only the base class part, whereas in the class template approach
the compiler gives an error.
    @makortel
    makortel committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    af62750 View commit details
    Browse the repository at this point in the history