Phase2-hgx334B Extend some of the calling sequences of Geometry to include zside which is needed to treat correctly cassette shifts #40404

bsunanda · 2022-12-23T09:43:08Z

PR description:

Extend some of the calling sequences of Geometry to include zside which is needed to treat correctly cassette shifts. There were several internal calls which were wrong in earlier versions. This may cause differences in predictions. Now all internal calls are checked and corrected.

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

…ch is needed to treat correctly cassette shifts

cmsbuild · 2022-12-23T09:52:02Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40404/33529

This PR adds an extra 64KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/HGCalCommonData/interface/HGCalCassette.h modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Geometry/HGCalCommonData/interface/HGCalDDDConstants.h modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Geometry/HGCalCommonData/src/HGCalCassette.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Geometry/HGCalCommonData/src/HGCalDDDConstants.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Geometry/HGCalCommonData/test/HGCalNumberingTester.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Geometry/HGCalCommonData/test/HGCalPartialWaferTester.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Geometry/HGCalGeometry/src/HGCalGeometry.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File SimCalorimetry/HGCalSimAlgos/interface/HGCalSiNoiseMap.icc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File SimG4CMS/Calo/interface/HGCalNumberingScheme.h modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File SimG4CMS/Calo/src/HFNoseNumberingScheme.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File SimG4CMS/Calo/src/HGCalNumberingScheme.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Validation/HGCalValidation/plugins/HGCGeometryValidation.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Validation/HGCalValidation/plugins/HGCalSimHitStudy.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Validation/HGCalValidation/plugins/HGCalSimHitValidation.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Validation/HGCalValidation/test/HGCHitValidation.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Validation/HGCalValidation/test/HGCalWaferStudy.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40404/33529/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40404/33529/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-12-23T10:01:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40404/33530

This PR adds an extra 84KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/HGCalCommonData/interface/HGCalCassette.h modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Geometry/HGCalCommonData/interface/HGCalDDDConstants.h modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Geometry/HGCalCommonData/src/HGCalCassette.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Geometry/HGCalCommonData/src/HGCalDDDConstants.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Geometry/HGCalCommonData/test/HGCalNumberingTester.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Geometry/HGCalCommonData/test/HGCalPartialWaferTester.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Geometry/HGCalGeometry/src/HGCalGeometry.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File SimCalorimetry/HGCalSimAlgos/interface/HGCalSiNoiseMap.icc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File SimG4CMS/Calo/interface/HGCalNumberingScheme.h modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File SimG4CMS/Calo/src/HFNoseNumberingScheme.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File SimG4CMS/Calo/src/HGCalNumberingScheme.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Validation/HGCalValidation/plugins/HGCGeometryValidation.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Validation/HGCalValidation/plugins/HGCalSimHitStudy.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Validation/HGCalValidation/plugins/HGCalSimHitValidation.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Validation/HGCalValidation/test/HGCHitValidation.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625
- File Validation/HGCalValidation/test/HGCalWaferStudy.cc modified in PR(s): Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry #39625

cmsbuild · 2022-12-23T10:02:06Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/HGCalCommonData (geometry, upgrade)
Geometry/HGCalGeometry (geometry, upgrade)
SimCalorimetry/HGCalSimAlgos (upgrade, simulation)
SimG4CMS/Calo (simulation)
Validation/HGCalValidation (dqm)

@civanch, @Dr15Jones, @bsunanda, @makortel, @emanueleusai, @ianna, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @mdhildreth, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@youyingli, @vandreev11, @fabiocos, @lecriste, @sethzenz, @missirol, @felicepantaleo, @rovere, @lgray, @cseez, @apsallid, @pfs, @thomreis, @hatakeyamak, @trtomei, @ebrondol, @sameasy, @beaucero, @slomeo, @simonepigazzini this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2022-12-23T12:12:29Z

@cmsbuild Please test

cmsbuild · 2022-12-23T15:55:57Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70bff5/29764/summary.html
COMMIT: 43225f6
CMSSW: CMSSW_13_0_X_2022-12-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40404/29764/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

20834.7620834.76_TTbar_14TeV+2026D88_HLTwDIGI75e33/step2_TTbar_14TeV+2026D88_HLTwDIGI75e33.log
23234.0

----- Begin Fatal Exception 23-Dec-2022 14:42:54 CET-----------------------
An exception of category 'OutOfBound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module L1TEGMultiMerger/'l1tLayer1EG'
   [4] Prefetching for module L1TCorrelatorLayer1Producer/'l1tLayer1HGCal'
   [5] Prefetching for module PFClusterProducerFromHGC3DClusters/'l1tPFClustersFromHGC3DClusters'
   [6] Calling method for module HGCalBackendLayer2Producer/'l1tHGCalBackEndLayer2Producer'
Exception Message:
TC X1 = 2.40758 out of the seeding histogram bounds 0.076 - 0.58
----- End Fatal Exception -------------------------------------------------

21034.999

----- Begin Fatal Exception 23-Dec-2022 14:46:00 CET-----------------------
An exception of category 'OutOfBound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module L1TEGMultiMerger/'l1tLayer1EG'
   [4] Prefetching for module L1TCorrelatorLayer1Producer/'l1tLayer1HGCal'
   [5] Prefetching for module PFClusterProducerFromHGC3DClusters/'l1tPFClustersFromHGC3DClusters'
   [6] Calling method for module HGCalBackendLayer2Producer/'l1tHGCalBackEndLayer2Producer'
Exception Message:
TC X1 = 2.9504 out of the seeding histogram bounds 0.076 - 0.58
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

20834.10320834.103_TTbar_14TeV+2026D88Aging3000/step2_TTbar_14TeV+2026D88Aging3000.log
21034.11421034.114_TTbar_14TeV+2026D88PU_OTInefficiency10PC/step2_TTbar_14TeV+2026D88PU_OTInefficiency10PC.log

cmsbuild · 2022-12-24T15:19:51Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70bff5/29765/summary.html
COMMIT: 8858165
CMSSW: CMSSW_13_0_X_2022-12-23-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40404/29765/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555748
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555723
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

bsunanda · 2022-12-25T04:53:43Z

+geometry

civanch · 2022-12-25T16:11:39Z

+1

bsunanda · 2022-12-30T13:35:31Z

@clacaputo, @mandrenguyen, @emanueleusai, @ahmad3213, @AdrianoDee, @srimanob Please approve this PR. Without this PR we cannot complete the full functionality of the V17 geometry of HGCal

mandrenguyen · 2022-12-30T13:48:24Z

+reconstruction
No diffs in comparisons.
Changes to reco modules consist basically of a new flag for zside

srimanob · 2023-01-03T05:14:32Z

+Upgrade

emanueleusai · 2023-01-07T04:22:43Z

+1

cmsbuild · 2023-01-07T04:23:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-01-07T14:24:13Z

+1

Extend some of the calling sequences of Geometry to include zside whi…

3823bbd

…ch is needed to treat correctly cassette shifts

cmsbuild added this to the CMSSW_13_0_X milestone Dec 23, 2022

cmsbuild added code-checks-pending dqm-pending geometry-pending orp-pending pending-signatures simulation-pending tests-pending upgrade-pending labels Dec 23, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Dec 23, 2022

Code check

43225f6

cmsbuild added code-checks-pending and removed code-checks-rejected labels Dec 23, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 23, 2022

cmsbuild added tests-started and removed tests-pending labels Dec 23, 2022

cmsbuild added tests-rejected and removed tests-started labels Dec 23, 2022

Get rid of all default settings in HGCalDDDConstant

3c9543c

cmsbuild added code-checks-pending and removed tests-rejected code-checks-approved labels Dec 24, 2022

cmsbuild added the tests-started label Dec 24, 2022

cmsbuild added tests-approved and removed tests-started labels Dec 24, 2022

cmsbuild added geometry-approved and removed geometry-pending labels Dec 25, 2022

cmsbuild added simulation-approved and removed simulation-pending labels Dec 25, 2022

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Dec 30, 2022

cmsbuild added upgrade-approved and removed upgrade-pending labels Jan 3, 2023

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jan 7, 2023

cmsbuild added orp-approved and removed orp-pending labels Jan 7, 2023

cmsbuild merged commit fedc937 into cms-sw:master Jan 7, 2023

cmsbuild mentioned this pull request Jan 9, 2023

Add missing include in FWCore/Utilities/src/path_configuration.cc #40452

Merged

srimanob mentioned this pull request Apr 19, 2023

Segfault in HGCalCassette::getShift() in workflow 25234.911 #41376

Closed

makortel mentioned this pull request Apr 27, 2023

Exception from HGCalBackendLayer2Producer #41451

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx334B Extend some of the calling sequences of Geometry to include zside which is needed to treat correctly cassette shifts #40404

Phase2-hgx334B Extend some of the calling sequences of Geometry to include zside which is needed to treat correctly cassette shifts #40404

bsunanda commented Dec 23, 2022 •

edited

cmsbuild commented Dec 23, 2022

cmsbuild commented Dec 23, 2022

cmsbuild commented Dec 23, 2022

bsunanda commented Dec 23, 2022

cmsbuild commented Dec 23, 2022

cmsbuild commented Dec 24, 2022

bsunanda commented Dec 25, 2022

civanch commented Dec 25, 2022

bsunanda commented Dec 30, 2022

mandrenguyen commented Dec 30, 2022

srimanob commented Jan 3, 2023

emanueleusai commented Jan 7, 2023

cmsbuild commented Jan 7, 2023

perrotta commented Jan 7, 2023

Phase2-hgx334B Extend some of the calling sequences of Geometry to include zside which is needed to treat correctly cassette shifts #40404

Phase2-hgx334B Extend some of the calling sequences of Geometry to include zside which is needed to treat correctly cassette shifts #40404

Conversation

bsunanda commented Dec 23, 2022 • edited

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Dec 23, 2022

cmsbuild commented Dec 23, 2022

cmsbuild commented Dec 23, 2022

bsunanda commented Dec 23, 2022

cmsbuild commented Dec 23, 2022

RelVals

RelVals-INPUT

cmsbuild commented Dec 24, 2022

Comparison Summary

bsunanda commented Dec 25, 2022

civanch commented Dec 25, 2022

bsunanda commented Dec 30, 2022

mandrenguyen commented Dec 30, 2022

srimanob commented Jan 3, 2023

emanueleusai commented Jan 7, 2023

cmsbuild commented Jan 7, 2023

perrotta commented Jan 7, 2023

bsunanda commented Dec 23, 2022 •

edited