Moved plugins to FWCore/Integration/plugins

[Dr15Jones]

PR description:

These were previously in the test directory. Also consolidated source files into fewer plugin shared libraries being made.

PR validation:

Code compiles and tests succeed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40448/33598

• This PR adds an extra 96KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Integration/test/ESTestProducers.cc modified in PR(s): Improve module type resolver system so that it would be usable for Alpaka modules #40383
  • File FWCore/Integration/test/BuildFile.xml modified in PR(s): Improve module type resolver system so that it would be usable for Alpaka modules #40383, Convert FWCore/Integration tests to catch2 #40430

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FWCore/Integration (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d562f/29825/summary.html
COMMIT: 87a7b22
CMSSW: CMSSW_13_0_X_2023-01-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40448/29825/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestIntegrationParameterSet had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 38 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555748
• DQMHistoTests: Total failures: 1197
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3554529
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40448/33619

• This PR adds an extra 108KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Integration/test/ESTestProducers.cc modified in PR(s): Improve module type resolver system so that it would be usable for Alpaka modules #40383
  • File FWCore/Integration/test/BuildFile.xml modified in PR(s): Convert FWCore/Integration tests to catch2 #40430, Improve module type resolver system so that it would be usable for Alpaka modules #40383

[cmsbuild]

Pull request #40448 was updated. @makortel, @smuzaffar, @Dr15Jones can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40448/33638

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #40448 was updated. @makortel, @smuzaffar, @Dr15Jones can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d562f/29882/summary.html
COMMIT: 974ebbd
CMSSW: CMSSW_13_0_X_2023-01-10-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40448/29882/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @perrotta Remove dead assignments and clean up a bit GenFilters #40287
• @fwyzard Add missing dependencies on TBB #40376

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d562f/29882/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d562f/29882/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555538
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555510
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

[wddgit]

Someone needs to fix a unit test related to a moved file. I guess the comment is also incorrect :) ... I'll do it unless someone else is already working on it...

https://cmssdt.cern.ch/dxr/CMSSW/source/FWCore/Integration/test/ProducerWithPSetDesc.cc#306

    // For purposes of the test, this just needs to point to any file
    // that exists.  I guess pointing to itself cannot ever fail ...
    edm::FileInPath fileInPath("FWCore/Integration/test/ProducerWithPSetDesc.cc");

[makortel]

@wddgit I don't think anyone is working on that, so feel free to go ahead.

[aandvalenzuela]

Hello @Dr15Jones, @wddgit
This PR also broke TestIntegrationParameterSet affecting all IB flavors. See #40519 (comment). Could you please have a look? Thanks!