Correct GEM edge calculation for TrackerMuons

[jo100sun]

PR description:

When filling chambermatches to TrackerMuon, it calculates edge distance of a muon track on the detector surface from the detector edge.
It is assuming the rectangular shape, but GEM detector is trapezoid.
So we fixed wrong edge distance calculation.

@watson-ij @jshlee

PR validation:

We ran a runThematrix test in run3 and phase2 Zmumu setup. We saw that edge is now calculating correctly in TrackerMuon. We reported this fixes in the muon dpgo meeting https://indico.cern.ch/event/1232229/contributions/5186787/attachments/2568843/4429266/20221216-muon-dpgo.pdf
and the GEM DPG meeting https://indico.cern.ch/event/1241721/contributions/5219032/attachments/2576699/4444051/Low%20efficiency%20at%20GE2_1%20in%20phase%202%20condition%20(5).pdf

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40554/33786

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40554/33786/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40554/33786/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40554/33787

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @jo100sun (Jo100) for master.

It involves the following packages:

• TrackingTools/TrackAssociator (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @abbiendi, @CeliaFernandez, @mmusich, @cericeci, @andrea21z, @JanFSchulte, @jhgoh, @missirol, @HuguesBrun, @trocino, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @ebrondol, @mtosi, @dgulhan, @Fedespring, @lecriste, @gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[watson-ij]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46aad4/30055/summary.html
COMMIT: 9384864
CMSSW: CMSSW_13_0_X_2023-01-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40554/30055/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40554/33791

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #40554 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

[watson-ij]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46aad4/30076/summary.html
COMMIT: dc988ac
CMSSW: CMSSW_13_0_X_2023-01-18-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40554/30076/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 245 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555479
• DQMHistoTests: Total failures: 89
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555368
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[slava77]

type -tracking

a case of false-positive in cms-sw/cms-bot#1916

[watson-ij]

I think the differences that are seen in the matches match what we expect: correcting the edge calculation will reject some GEM matches that were previously accepted (inside the rectangular boundary, but not in the trapezoidal boundary). This decrease can be seen in the recoMuons_displacedMuons__RECO_obj_muMatches__detector plots. Then with fewer chamber matches, the corresponding chamber match plots will all have fewer entries.

[mandrenguyen]

+reconstruction
Changes are observed to muon-related quantities in line with PR description.

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.