New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmsDriver.py
: flush stdout buffer before call to os.execvpe
#40635
cmsDriver.py
: flush stdout buffer before call to os.execvpe
#40635
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40635/33930
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@cmsbuild, @perrotta, @rappoccio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fbb71/30232/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
type bugfix |
PR description:
This PR updates the script
cmsDriver.py
adding a call tosys.stdout.flush()
right beforeos.execvpe
is used to executecmsRun
. As explained in the documentation ofos.execvpe
, this ensures that the stdout buffer is flushed before theos.execvpe
call replaces the current process.Currently (i.e. without this PR), redirecting the output of
cmsDriver.py
to a log file may result in the latter not containining all the printouts ofcmsDriver.py
(if the--no_exec
option is not used). This means that this PR will increase the size of the logs of RelVal tests in PRs.For further details, see also #40599 (comment).
PR validation:
runTheMatrix.py -l 136.731
If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
N/A