Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VtxSmearing scenario for 2022 EOY MC #40662

Merged
merged 1 commit into from Feb 3, 2023

Conversation

francescobrivio
Copy link
Contributor

PR description:

This PR adds a new VtxSmearing scenario Realistic25ns13p6TeVEOY2022Collision which better represents the BeamSpot in 2022 (with respect to the previously used Early2022 smearing) and will be used for the "EOY" 2022 MC campaigns, later this year:

This set of VtxSmearing parameters has been discussed (and approved) at the Joint Tracker DPG / Tracking POG meeting during CMS week.

PR validation:

None
At the moment the new smearing is not used anywhere and we will have to go through the usual action-items
before actually deploying it:

  • this PR:
    • include the smearing in a pre-release
  • "offline":
    • generate relvals with the new smearing
    • fit the reco-BeamSpot
  • future PR
    • include the new reco-BeamSpot in the GTs and the workflows

Backport:

Not a backport, no backport needed

@francescobrivio
Copy link
Contributor Author

FYI @cms-sw/alca-l2 @dzuolo @lguzzi @gennai @cms-sw/tracking-pog-l2 @cms-sw/trk-dpg-l2

@francescobrivio
Copy link
Contributor Author

urgent

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

VtxSmeared = cms.EDProducer("BetafuncEvtVtxGenerator",
Realistic25ns13p6TeVEOY2022CollisionVtxSmearingParameters,
VtxSmearedCommon
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

picky - but there is no newline at the end of the file ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right I missed it.
I will fix this in the next PR (when we include the reco-BS and the new workflows).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@francescobrivio , usually we fix promptly such requests. I will sign this PR but do not understand urgency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@civanch thanks for signing this!

usually we fix promptly such requests

When I saw Marco's comment the tests had already started, so I didn't want to stop and repeat them just for a cosmetic empty line

I will sign this PR but do not understand urgency.

The urgency is to get this in 13_0_0_pre4, so we can get the reco-BS (and the matrix workflows) in 13_0_0 and get a proper validation.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40662/34000

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2023

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • IOMC/EventVertexGenerators (simulation)

@perrotta, @rappoccio, @civanch, @mdhildreth, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @grzanka, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be0fc9/30335/summary.html
COMMIT: 9b40fb3
CMSSW: CMSSW_13_0_X_2023-01-31-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40662/30335/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555495
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555470
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Feb 1, 2023

@cmsbuild , please test

  • tho not sure there is any point to it, the new beamspot is not in any wfs, right?

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be0fc9/30345/summary.html
COMMIT: 9b40fb3
CMSSW: CMSSW_13_0_X_2023-01-31-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40662/30345/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555495
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555470
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Feb 2, 2023

+1

@perrotta
Copy link
Contributor

perrotta commented Feb 3, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants