New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VtxSmearing scenario for 2022 EOY MC #40662
Conversation
urgent
|
@cmsbuild please test |
VtxSmeared = cms.EDProducer("BetafuncEvtVtxGenerator", | ||
Realistic25ns13p6TeVEOY2022CollisionVtxSmearingParameters, | ||
VtxSmearedCommon | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
picky - but there is no newline at the end of the file ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right I missed it.
I will fix this in the next PR (when we include the reco-BS and the new workflows).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@francescobrivio , usually we fix promptly such requests. I will sign this PR but do not understand urgency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@civanch thanks for signing this!
usually we fix promptly such requests
When I saw Marco's comment the tests had already started, so I didn't want to stop and repeat them just for a cosmetic empty line
I will sign this PR but do not understand urgency.
The urgency is to get this in 13_0_0_pre4, so we can get the reco-BS (and the matrix workflows) in 13_0_0 and get a proper validation.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40662/34000
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@perrotta, @rappoccio, @civanch, @mdhildreth, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
@cmsbuild , please test
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be0fc9/30345/summary.html Comparison SummarySummary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR adds a new VtxSmearing scenario
Realistic25ns13p6TeVEOY2022Collision
which better represents the BeamSpot in 2022 (with respect to the previously usedEarly2022
smearing) and will be used for the "EOY" 2022 MC campaigns, later this year:This set of VtxSmearing parameters has been discussed (and approved) at the Joint Tracker DPG / Tracking POG meeting during CMS week.
PR validation:
None
At the moment the new smearing is not used anywhere and we will have to go through the usual action-items
before actually deploying it:
Backport:
Not a backport, no backport needed