Add try/catch in OnlineBeamMonitor plugin to resolve runtime error

[francescobrivio]

resolves #39948

PR description:

This PR addesses the issue observed in a technical test by @missirol and reported in #39948 where the BeamOnlineMonitor is run offline (although it's meant to be run online only) on data older than Run 3.

The solution implemented was suggested by @mmusich in #39948 (comment) and it's basically copied (with minor modifications) from the same try/catch approach used in the BeamSpotOnline_PayloadInspector plugin.

The [RFC] is beacuse I'm not sure if adding the functions for this check directly in the .cc is fine or not.
The solution nonetheless works as expected.

PR validation:

Successfully tested using the recipe prodvided by Marino in #39948 (comment): the Fatal Exception is now gone and replaced by a LogError message just like in the Payload Inspector plugin.

Backport:

Not a backport.
I'm reluctant to provide a backport to 12_6_X beacuse online the BeamSpot is computed with collision only, and data taking for pp data will happen in 13_0_X AFAIU. Of course if @cms-sw/dqm-l2 (or others) disagree I'm happy to provide a 12_6_X backport as well.

FYI @dzuolo @gennai @lguzzi

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40716/34101

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

• DQM/BeamMonitor (dqm, db)

@malbouis, @pmandrik, @emanueleusai, @tvami, @cmsbuild, @saumyaphor4252, @syuvivida, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40716/34105

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #40716 was updated. @malbouis, @pmandrik, @emanueleusai, @tvami, @cmsbuild, @saumyaphor4252, @syuvivida, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80b02d/30471/summary.html
COMMIT: 3bb9db9
CMSSW: CMSSW_13_0_X_2023-02-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40716/30471/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 11 lines from the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555852
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555827
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

agree 12_6 backport not needed if collisions will use 13_X

[emanueleusai]

+1

[mmusich]

@cmsbuild, please abort

[mmusich]

@cmsbuild, please test with #40727

[mmusich]

@cms-sw/db-l2 unit tests have finally passed :) log.
Feel free to sign if you are otherwise OK with this.
@francescobrivio I guess you can remove the RFC at this point.

[saumyaphor4252]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80b02d/30539/summary.html
COMMIT: 3bb9db9
CMSSW: CMSSW_13_0_X_2023-02-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40716/30539/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 17 lines from the logs
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555852
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555824
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• Let merge this as such,so that it can be included in pre4
• Add try/catch in OnlineBeamMonitor plugin to resolve runtime error #40716 (comment) can be followed up in the development release, which will move to 13_1_X afterward

[fwyzard]

The CMS coding rules state explicitly

7 – Design and Coding Guidelines

...
11. - In general, do not catch exceptions – leave them to the Framework